You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/30 15:48:51 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request #7676: fix mysql create table and insert statement parse error
strongduanmu opened a new pull request #7676:
URL: https://github.com/apache/shardingsphere/pull/7676
Fixes #7662.
Changes proposed in this pull request:
- fix insert statement contains binary operation rewrite error
- fix create table contains `ON UPDATE CURRENT_TIMESTAMP` clause parse error
- fix create table contains [other vendor data type](https://dev.mysql.com/doc/refman/8.0/en/other-vendor-data-types.html) parse error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7676: fix mysql create table and insert statement parse error
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7676:
URL: https://github.com/apache/shardingsphere/pull/7676#issuecomment-701526338
## Pull Request Test Coverage Report for [Build 15199](https://coveralls.io/builds/33836685)
* **1** of **2** **(50.0%)** changed or added relevant lines in **1** file are covered.
* **7757** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.05%**) to **35.348%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-infra/shardingsphere-infra-rewrite/shardingsphere-infra-rewrite-engine/src/main/java/org/apache/shardingsphere/infra/rewrite/sql/token/pojo/generic/InsertValue.java](https://coveralls.io/builds/33836685/source?filename=shardingsphere-infra%2Fshardingsphere-infra-rewrite%2Fshardingsphere-infra-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Frewrite%2Fsql%2Ftoken%2Fpojo%2Fgeneric%2FInsertValue.java#L58) | 1 | 2 | 50.0%
<!-- | **Total:** | **1** | **2** | **50.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/MySQLStatementParser.java](https://coveralls.io/builds/33836685/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-mysql%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FMySQLStatementParser.java#L19664) | 7757 | 21.75% |
<!-- | **Total:** | **7757** | | -->
| Totals | [](https://coveralls.io/builds/33836685) |
| :-- | --: |
| Change from base [Build 15198](https://coveralls.io/builds/33835973): | 0.05% |
| Covered Lines: | 37005 |
| Relevant Lines: | 104688 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #7676: fix mysql create table and insert statement parse error
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7676:
URL: https://github.com/apache/shardingsphere/pull/7676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org