You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by David Robson <da...@quest.com> on 2014/11/19 04:10:16 UTC

Review Request 28212: Numeric Overflow when getting extent map

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28212/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1764
    https://issues.apache.org/jira/browse/SQOOP-1764


Repository: sqoop-trunk


Description
-------

Changed block ID from int to long.


Diffs
-----

  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunk.java bc94abd 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java 5262d0e 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java fbd8a16 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleQueries.java b65d009 
  src/test/org/apache/sqoop/manager/oracle/OraOopOracleQueriesTest.java 09314da 

Diff: https://reviews.apache.org/r/28212/diff/


Testing
-------

Added a unit test with a large block ID - couldn't test on an actual DB though as we don't have a big enough database to reproduce the issue.


Thanks,

David Robson

Re: Review Request 28212: Numeric Overflow when getting extent map

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28212/#review62121
-----------------------------------------------------------

Ship it!


Good catch!

- Venkat Ranganathan


On Nov. 19, 2014, 3:10 a.m., David Robson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28212/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2014, 3:10 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1764
>     https://issues.apache.org/jira/browse/SQOOP-1764
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Changed block ID from int to long.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunk.java bc94abd 
>   src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java 5262d0e 
>   src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java fbd8a16 
>   src/java/org/apache/sqoop/manager/oracle/OraOopOracleQueries.java b65d009 
>   src/test/org/apache/sqoop/manager/oracle/OraOopOracleQueriesTest.java 09314da 
> 
> Diff: https://reviews.apache.org/r/28212/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test with a large block ID - couldn't test on an actual DB though as we don't have a big enough database to reproduce the issue.
> 
> 
> Thanks,
> 
> David Robson
> 
>