You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Michael Bouschen (JIRA)" <ji...@apache.org> on 2006/03/28 17:37:21 UTC

[jira] Created: (JDO-353) Fix issues reported by checkstyle in api20 subproject

Fix issues reported by checkstyle in api20 subproject
-----------------------------------------------------

         Key: JDO-353
         URL: http://issues.apache.org/jira/browse/JDO-353
     Project: JDO
        Type: Improvement
  Components: api20  
    Versions: JDO 2 rc1    
    Reporter: Michael Bouschen
 Assigned to: Michael Bouschen 
    Priority: Trivial
     Fix For: JDO 2 final


Today I did a maven site on the api20 subproject. This includes running checkstyle on the api20 sources which reports 83 "errors". These are not real errors, but maybe cleanup items we want to do before shipping: lines being longer than 100 chars, unused imports, file not ending  with a newline, array brackets at illegal position. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (JDO-353) Fix issues reported by checkstyle in api20 subproject

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/JDO-353?page=comments#action_12372149 ] 

Craig Russell commented on JDO-353:
-----------------------------------

A few of the lines now or still exceed 80 characters. Can you run the stlyecheck again with the new files?

These are the files I found where the changed file still contains lines > 80 characters:

src/java/javax/jdo/listener/AttachCallback.java
src/java/javax/jdo/Query.java
src/java/javax/jdo/PersistenceManagerFactory.java
src/java/javax/jdo/spi/JDOPermission.java
src/java/javax/jdo/spi/StateManager.java
src/java/javax/jdo/spi/JDOImplHelper.java
src/java/javax/jdo/JDOHelper.java
src/java/javax/jdo/PersistenceManager.java
src/java/javax/jdo/Transaction.java

I didn't find anything else to complain about.


> Fix issues reported by checkstyle in api20 subproject
> -----------------------------------------------------
>
>          Key: JDO-353
>          URL: http://issues.apache.org/jira/browse/JDO-353
>      Project: JDO
>         Type: Improvement
>   Components: api20
>     Versions: JDO 2 rc1
>     Reporter: Michael Bouschen
>     Assignee: Michael Bouschen
>     Priority: Trivial
>      Fix For: JDO 2 final
>  Attachments: JDO-353.patch
>
> Today I did a maven site on the api20 subproject. This includes running checkstyle on the api20 sources which reports 83 "errors". These are not real errors, but maybe cleanup items we want to do before shipping: lines being longer than 100 chars, unused imports, file not ending  with a newline, array brackets at illegal position. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (JDO-353) Fix issues reported by checkstyle in api20 subproject

Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-353?page=all ]
     
Michael Bouschen resolved JDO-353:
----------------------------------

    Resolution: Fixed

Checked in the fix.

Sende          api20\src\java\javax\jdo\JDODetachedFieldAccessException.java
Sende          api20\src\java\javax\jdo\JDOHelper.java
Sende          api20\src\java\javax\jdo\JDOOptimisticVerificationException.java
Sende          api20\src\java\javax\jdo\PersistenceManager.java
Sende          api20\src\java\javax\jdo\PersistenceManagerFactory.java
Sende          api20\src\java\javax\jdo\Query.java
Sende          api20\src\java\javax\jdo\Transaction.java
Sende          api20\src\java\javax\jdo\datastore\JDOConnection.java
Sende          api20\src\java\javax\jdo\datastore\Sequence.java
Sende          api20\src\java\javax\jdo\identity\ObjectIdentity.java
Sende          api20\src\java\javax\jdo\identity\StringIdentity.java
Sende          api20\src\java\javax\jdo\listener\AttachCallback.java
Sende          api20\src\java\javax\jdo\listener\AttachLifecycleListener.java
Sende          api20\src\java\javax\jdo\listener\ClearLifecycleListener.java
Sende          api20\src\java\javax\jdo\listener\CreateLifecycleListener.java
Sende          api20\src\java\javax\jdo\listener\DeleteLifecycleListener.java
Sende          api20\src\java\javax\jdo\listener\DetachCallback.java
Sende          api20\src\java\javax\jdo\listener\DetachLifecycleListener.java
Sende          api20\src\java\javax\jdo\listener\DirtyLifecycleListener.java
Sende          api20\src\java\javax\jdo\listener\InstanceLifecycleEvent.java
Sende          api20\src\java\javax\jdo\listener\InstanceLifecycleListener.java
Sende          api20\src\java\javax\jdo\listener\LoadLifecycleListener.java
Sende          api20\src\java\javax\jdo\listener\StoreLifecycleListener.java
Sende          api20\src\java\javax\jdo\spi\I18NHelper.java
Sende          api20\src\java\javax\jdo\spi\JDOImplHelper.java
Sende          api20\src\java\javax\jdo\spi\JDOPermission.java
Sende          api20\src\java\javax\jdo\spi\PersistenceCapable.java
Sende          api20\src\java\javax\jdo\spi\StateInterrogation.java
Sende          api20\src\java\javax\jdo\spi\StateManager.java
?\195?\156bertrage Daten .............................
Revision 389615 ?\195?\188bertragen.

> Fix issues reported by checkstyle in api20 subproject
> -----------------------------------------------------
>
>          Key: JDO-353
>          URL: http://issues.apache.org/jira/browse/JDO-353
>      Project: JDO
>         Type: Improvement
>   Components: api20
>     Versions: JDO 2 rc1
>     Reporter: Michael Bouschen
>     Assignee: Michael Bouschen
>     Priority: Trivial
>      Fix For: JDO 2 final
>  Attachments: JDO-353.patch
>
> Today I did a maven site on the api20 subproject. This includes running checkstyle on the api20 sources which reports 83 "errors". These are not real errors, but maybe cleanup items we want to do before shipping: lines being longer than 100 chars, unused imports, file not ending  with a newline, array brackets at illegal position. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (JDO-353) Fix issues reported by checkstyle in api20 subproject

Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-353?page=all ]

Michael Bouschen updated JDO-353:
---------------------------------

    Attachment: JDO-353.patch

Please review the attached patch JDO-353.patch.

> Fix issues reported by checkstyle in api20 subproject
> -----------------------------------------------------
>
>          Key: JDO-353
>          URL: http://issues.apache.org/jira/browse/JDO-353
>      Project: JDO
>         Type: Improvement
>   Components: api20
>     Versions: JDO 2 rc1
>     Reporter: Michael Bouschen
>     Assignee: Michael Bouschen
>     Priority: Trivial
>      Fix For: JDO 2 final
>  Attachments: JDO-353.patch
>
> Today I did a maven site on the api20 subproject. This includes running checkstyle on the api20 sources which reports 83 "errors". These are not real errors, but maybe cleanup items we want to do before shipping: lines being longer than 100 chars, unused imports, file not ending  with a newline, array brackets at illegal position. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira