You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/06 14:43:19 UTC

[GitHub] [incubator-devlake] keon94 opened a new pull request, #2984: [fix-2940][framework]: Add lazy caching of http codes for error handling

keon94 opened a new pull request, #2984:
URL: https://github.com/apache/incubator-devlake/pull/2984

   ### ⚠️ Pre Checklist
   
   > Please complete _ALL_ items in this checklist, and remove before submitting
   
   - [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
   - [ ] I have added relevant tests.
   - [ ] I have added relevant documentation.
   - [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
   
   
   
   # Summary
   
   <!--
   Thanks for submitting a pull request!
   
   We appreciate you spending the time to work on these changes.
   Please fill out as many sections below as possible.
   -->
   
   ### Does this close any open issues?
   Closes xx
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] keon94 commented on pull request #2984: [fix-2940][framework]: Add lazy caching of http codes for error handling and fix any broken Http error messages

Posted by GitBox <gi...@apache.org>.
keon94 commented on PR #2984:
URL: https://github.com/apache/incubator-devlake/pull/2984#issuecomment-1244778988

   Fix for #3031 screenshot:
   ![image](https://user-images.githubusercontent.com/25063936/189785922-9d118715-e04d-43ce-9751-1b405cd281c2.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] keon94 commented on pull request #2984: [fix-2940][framework]: Add lazy caching of http codes for error handling and fix any broken Http error messages

Posted by GitBox <gi...@apache.org>.
keon94 commented on PR #2984:
URL: https://github.com/apache/incubator-devlake/pull/2984#issuecomment-1244790862

   > Fix for #3031 screenshot: ![image](https://user-images.githubusercontent.com/25063936/189785922-9d118715-e04d-43ce-9751-1b405cd281c2.png)
   
   error status is now 400 like before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh commented on pull request #2984: [fix-2940][framework]: Add lazy caching of http codes for error handling and fix any broken Http error messages

Posted by GitBox <gi...@apache.org>.
klesh commented on PR #2984:
URL: https://github.com/apache/incubator-devlake/pull/2984#issuecomment-1244813345

   @keon94 Does it fix #2940? Could you provide screenshot for it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] keon94 commented on pull request #2984: [fix-2940][framework]: Add lazy caching of http codes for error handling and fix any broken Http error messages

Posted by GitBox <gi...@apache.org>.
keon94 commented on PR #2984:
URL: https://github.com/apache/incubator-devlake/pull/2984#issuecomment-1242563781

   @klesh this is ready for review. I tuned things in accordance with the proposal [here](https://github.com/apache/incubator-devlake/issues/3031#issuecomment-1242545195). cc @e2corporation 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] keon94 commented on pull request #2984: [fix-2940][framework]: Add lazy caching of http codes for error handling and fix any broken Http error messages

Posted by GitBox <gi...@apache.org>.
keon94 commented on PR #2984:
URL: https://github.com/apache/incubator-devlake/pull/2984#issuecomment-1244825649

   @klesh Yes.
   ![image](https://user-images.githubusercontent.com/25063936/189796004-6250b6e9-57e0-4113-8962-39b3ccc7ed80.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] keon94 commented on pull request #2984: [fix-2940][framework]: Add lazy caching of http codes for error handling and fix any broken Http error messages

Posted by GitBox <gi...@apache.org>.
keon94 commented on PR #2984:
URL: https://github.com/apache/incubator-devlake/pull/2984#issuecomment-1244500872

   Sample plugin execution failure (error message display fixed)
   ![image](https://user-images.githubusercontent.com/25063936/189761226-92e0421c-befd-4e0c-ab0d-a61b6bf524ed.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh merged pull request #2984: [fix-2940][framework]: Add lazy caching of http codes for error handling and fix any broken Http error messages

Posted by GitBox <gi...@apache.org>.
klesh merged PR #2984:
URL: https://github.com/apache/incubator-devlake/pull/2984


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org