You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/15 09:21:14 UTC

[GitHub] [hudi] pratyakshsharma commented on issue #5020: [SUPPORT] The cleaning strategy breaks the reader view completeness

pratyakshsharma commented on issue #5020:
URL: https://github.com/apache/hudi/issues/5020#issuecomment-1247828014

   I guess https://github.com/apache/hudi/pull/5406 does not address the issue discussed here. As per this comment by Danny - https://github.com/apache/hudi/issues/5020#issuecomment-1121853297, C10 is affecting some file slice written in C1 and cleaner cleans the V1 of that file slice. 
   
   If the commits to retain is set to 6 (as in the first comment in this issue), C1 is not getting affected by the fix in https://github.com/apache/hudi/pull/5406. In that PR, we are more concerned about if C4 should be cleaned or not. The previous commits will anyways be cleaned as per the logic. Using KEEP_LATEST_FILE_VERSIONS seems to be a good fix for the issue reported though. @nsivabalan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org