[jira] [Commented] (CXF-5688) Problem Parsing FIQL Involving Enums

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154605#comment-15154605 ] 

ASF GitHub Bot commented on CXF-5688:
-------------------------------------

GitHub user azitabh opened a pull request:

    https://github.com/apache/cxf/pull/111

    enhancing readability #CXF-5688

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/azitabh/cxf master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #111
    
----
commit c27f5fb93f9244882c590f6ffca97ac5c05a7e68
Author: Azitabh Ajit <az...@gmail.com>
Date:   2014-10-07T06:31:22Z

    enhancing readability #CXF-5688

----


> Problem Parsing FIQL Involving Enums
> ------------------------------------
>
>                 Key: CXF-5688
>                 URL: https://issues.apache.org/jira/browse/CXF-5688
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>            Reporter: Azitabh
>            Assignee: Sergey Beryozkin
>            Priority: Minor
>             Fix For: 3.0.0, 2.7.12
>
>
> FIQL parser assumes that enums would be defined in all caps. 
> In case Enums are not defined in all caps, InjectionUtils.convertStringToPrimitive(String value, Class<?> cls) raises PropertyNotFoundException because it's converting the user provided enum value to caps and calling ENUM.valueOf(UPPERCASE_STR).
> ethod m  = cls.getMethod("valueOf", new Class[]{String.class});
> return m.invoke(null, value.toUpperCase());
> Since JAVA doesn't enforce enums to be all caps, I don't see any reason why FIQLParser should assume this.
> https://github.com/apache/cxf/blob/master/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/InjectionUtils.java 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)