You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/02/05 07:48:17 UTC

[GitHub] [hadoop] mithmatt commented on a change in pull request #2639: HDFS-15785. Datanode to support using DNS to resolve nameservices to IP addresses to get list of namenodes.

mithmatt commented on a change in pull request #2639:
URL: https://github.com/apache/hadoop/pull/2639#discussion_r570776436



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
##########
@@ -1557,6 +1557,17 @@
   public static final double
       DFS_DATANODE_RESERVE_FOR_ARCHIVE_DEFAULT_PERCENTAGE_DEFAULT = 0.0;
 
+
+  public static final String
+      DFS_RESOLVE_NAMESERVICE_NEEDED =
+      "dfs.resolve.nameservice.needed";

Review comment:
       "dfs.nameservices.resolution.enabled" or "dfs.nameservices.resolution-enabled" may be a better property name
   
   

##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
##########
@@ -1557,6 +1557,17 @@
   public static final double
       DFS_DATANODE_RESERVE_FOR_ARCHIVE_DEFAULT_PERCENTAGE_DEFAULT = 0.0;
 
+
+  public static final String
+      DFS_RESOLVE_NAMESERVICE_NEEDED =
+      "dfs.resolve.nameservice.needed";
+  public static final boolean
+      DFS_RESOLVE_NAMESERVICE_NEEDED_DEFAULT = false;
+
+  public static final String
+      DFS_RESOLVER_IMPL =
+      "dfs.resolver.impl";

Review comment:
       May be "dfs.nameservices.resolver.impl" ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org