You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Holger Hoffstätte (JIRA)" <ji...@apache.org> on 2011/01/14 15:33:45 UTC
[jira] Created: (AVRO-733) Avro Java r1059016 does not build due to
Checkstyle faulure
Avro Java r1059016 does not build due to Checkstyle faulure
-----------------------------------------------------------
Key: AVRO-733
URL: https://issues.apache.org/jira/browse/AVRO-733
Project: Avro
Issue Type: Bug
Components: java
Affects Versions: 1.5.0
Environment: Win7, JDK6, maven 3.0.2
Reporter: Holger Hoffstätte
Priority: Critical
Fix For: 1.5.0
Trying to build avro-java from svn trunk fails in checkstyle:
"Unused import - org.apache.avro.UnresolvedUnionException" in
ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-733) Avro Java r1059016 does not build due
to Checkstyle faulure
Posted by "Holger Hoffstätte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981909#action_12981909 ]
Holger Hoffstätte commented on AVRO-733:
----------------------------------------
Agreed, binding to test phase is good. My primary stumbling block was that I had to run install before eclipse (no m2eclipse plugin here) and that failed, so I got nowhere until I found the checkstyle.skip flag..
> Avro Java r1059016 does not build due to Checkstyle faulure
> -----------------------------------------------------------
>
> Key: AVRO-733
> URL: https://issues.apache.org/jira/browse/AVRO-733
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Environment: Win7, JDK6, maven 3.0.2
> Reporter: Holger Hoffstätte
> Assignee: Scott Carey
> Priority: Critical
> Fix For: 1.5.0
>
> Attachments: AVRO-733.patch
>
>
> Trying to build avro-java from svn trunk fails in checkstyle:
> "Unused import - org.apache.avro.UnresolvedUnionException" in
> ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
> I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-733) Avro Java r1059016 does not build due to
Checkstyle faulure
Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Carey updated AVRO-733:
-----------------------------
Attachment: AVRO-733.patch
> Avro Java r1059016 does not build due to Checkstyle faulure
> -----------------------------------------------------------
>
> Key: AVRO-733
> URL: https://issues.apache.org/jira/browse/AVRO-733
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Environment: Win7, JDK6, maven 3.0.2
> Reporter: Holger Hoffstätte
> Assignee: Scott Carey
> Priority: Critical
> Fix For: 1.5.0
>
> Attachments: AVRO-733.patch
>
>
> Trying to build avro-java from svn trunk fails in checkstyle:
> "Unused import - org.apache.avro.UnresolvedUnionException" in
> ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
> I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-733) Avro Java r1059016 does not build due
to Checkstyle faulure
Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981901#action_12981901 ]
Scott Carey commented on AVRO-733:
----------------------------------
I'll move checkstyle to the test phase and commit that on this JIRA later today unless there are objections.
> Avro Java r1059016 does not build due to Checkstyle faulure
> -----------------------------------------------------------
>
> Key: AVRO-733
> URL: https://issues.apache.org/jira/browse/AVRO-733
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Environment: Win7, JDK6, maven 3.0.2
> Reporter: Holger Hoffstätte
> Assignee: Scott Carey
> Priority: Critical
> Fix For: 1.5.0
>
> Attachments: AVRO-733.patch
>
>
> Trying to build avro-java from svn trunk fails in checkstyle:
> "Unused import - org.apache.avro.UnresolvedUnionException" in
> ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
> I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-733) Avro Java r1059016 does not build due
to Checkstyle faulure
Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981859#action_12981859 ]
Scott Carey commented on AVRO-733:
----------------------------------
Note that 'mvn install' will run checkstyle. 'mvn test' will not.
Documentation on the new build is not complete yet (AVRO-714) -- proper testing before a checkin requires 'mvn install' rather than only 'mvn test'. Alternatively we could attach checkstyle to the 'test' phase.
> Avro Java r1059016 does not build due to Checkstyle faulure
> -----------------------------------------------------------
>
> Key: AVRO-733
> URL: https://issues.apache.org/jira/browse/AVRO-733
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Environment: Win7, JDK6, maven 3.0.2
> Reporter: Holger Hoffstätte
> Assignee: Scott Carey
> Priority: Critical
> Fix For: 1.5.0
>
> Attachments: AVRO-733.patch
>
>
> Trying to build avro-java from svn trunk fails in checkstyle:
> "Unused import - org.apache.avro.UnresolvedUnionException" in
> ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
> I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-733) Avro Java r1059016 does not build due
to Checkstyle faulure
Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981824#action_12981824 ]
Scott Carey commented on AVRO-733:
----------------------------------
I noticed this last night as well and was planning on addressing it with some other things. Very simple patch to follow.
> Avro Java r1059016 does not build due to Checkstyle faulure
> -----------------------------------------------------------
>
> Key: AVRO-733
> URL: https://issues.apache.org/jira/browse/AVRO-733
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Environment: Win7, JDK6, maven 3.0.2
> Reporter: Holger Hoffstätte
> Assignee: Scott Carey
> Priority: Critical
> Fix For: 1.5.0
>
>
> Trying to build avro-java from svn trunk fails in checkstyle:
> "Unused import - org.apache.avro.UnresolvedUnionException" in
> ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
> I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-733) Avro Java r1059016 does not build due
to Checkstyle faulure
Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981831#action_12981831 ]
Scott Carey commented on AVRO-733:
----------------------------------
Unless there are objections, I'll commit this later today.
> Avro Java r1059016 does not build due to Checkstyle faulure
> -----------------------------------------------------------
>
> Key: AVRO-733
> URL: https://issues.apache.org/jira/browse/AVRO-733
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Environment: Win7, JDK6, maven 3.0.2
> Reporter: Holger Hoffstätte
> Assignee: Scott Carey
> Priority: Critical
> Fix For: 1.5.0
>
> Attachments: AVRO-733.patch
>
>
> Trying to build avro-java from svn trunk fails in checkstyle:
> "Unused import - org.apache.avro.UnresolvedUnionException" in
> ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
> I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-733) Avro Java r1059016 does not build due to
Checkstyle faulure
Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Carey updated AVRO-733:
-----------------------------
Attachment: AVRO-733.2.patch
tiny patch to change checkstyle to be bound to the 'test' phase instead of the 'verify' phase.
> Avro Java r1059016 does not build due to Checkstyle faulure
> -----------------------------------------------------------
>
> Key: AVRO-733
> URL: https://issues.apache.org/jira/browse/AVRO-733
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Environment: Win7, JDK6, maven 3.0.2
> Reporter: Holger Hoffstätte
> Assignee: Scott Carey
> Priority: Critical
> Fix For: 1.5.0
>
> Attachments: AVRO-733.2.patch, AVRO-733.patch
>
>
> Trying to build avro-java from svn trunk fails in checkstyle:
> "Unused import - org.apache.avro.UnresolvedUnionException" in
> ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
> I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AVRO-733) Avro Java r1059016 does not build due
to Checkstyle faulure
Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Carey reassigned AVRO-733:
--------------------------------
Assignee: Scott Carey
> Avro Java r1059016 does not build due to Checkstyle faulure
> -----------------------------------------------------------
>
> Key: AVRO-733
> URL: https://issues.apache.org/jira/browse/AVRO-733
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Environment: Win7, JDK6, maven 3.0.2
> Reporter: Holger Hoffstätte
> Assignee: Scott Carey
> Priority: Critical
> Fix For: 1.5.0
>
>
> Trying to build avro-java from svn trunk fails in checkstyle:
> "Unused import - org.apache.avro.UnresolvedUnionException" in
> ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
> I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-733) Avro Java r1059016 does not build due
to Checkstyle faulure
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981876#action_12981876 ]
Doug Cutting commented on AVRO-733:
-----------------------------------
+1 for adding checkstyle to the 'test' phase, to better prevent this sort of thing in the future.
> Avro Java r1059016 does not build due to Checkstyle faulure
> -----------------------------------------------------------
>
> Key: AVRO-733
> URL: https://issues.apache.org/jira/browse/AVRO-733
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Environment: Win7, JDK6, maven 3.0.2
> Reporter: Holger Hoffstätte
> Assignee: Scott Carey
> Priority: Critical
> Fix For: 1.5.0
>
> Attachments: AVRO-733.patch
>
>
> Trying to build avro-java from svn trunk fails in checkstyle:
> "Unused import - org.apache.avro.UnresolvedUnionException" in
> ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
> I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AVRO-733) Avro Java r1059016 does not build due
to Checkstyle faulure
Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Carey resolved AVRO-733.
------------------------------
Resolution: Fixed
I have committed this.
> Avro Java r1059016 does not build due to Checkstyle faulure
> -----------------------------------------------------------
>
> Key: AVRO-733
> URL: https://issues.apache.org/jira/browse/AVRO-733
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Environment: Win7, JDK6, maven 3.0.2
> Reporter: Holger Hoffstätte
> Assignee: Scott Carey
> Priority: Critical
> Fix For: 1.5.0
>
> Attachments: AVRO-733.patch
>
>
> Trying to build avro-java from svn trunk fails in checkstyle:
> "Unused import - org.apache.avro.UnresolvedUnionException" in
> ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
> I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-733) Avro Java r1059016 does not build due
to Checkstyle faulure
Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981970#action_12981970 ]
Scott Carey commented on AVRO-733:
----------------------------------
checkstyle changed to 'test' phase from 'verify' phase.
> Avro Java r1059016 does not build due to Checkstyle faulure
> -----------------------------------------------------------
>
> Key: AVRO-733
> URL: https://issues.apache.org/jira/browse/AVRO-733
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Environment: Win7, JDK6, maven 3.0.2
> Reporter: Holger Hoffstätte
> Assignee: Scott Carey
> Priority: Critical
> Fix For: 1.5.0
>
> Attachments: AVRO-733.2.patch, AVRO-733.patch
>
>
> Trying to build avro-java from svn trunk fails in checkstyle:
> "Unused import - org.apache.avro.UnresolvedUnionException" in
> ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java
> I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.