[jira] [Commented] (TEZ-4148) Make Number Of Tez AM Attempts Configurable When DAG Recovery Is Disabled

["Syed Shameerur Rahman (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084673#comment-17084673 ] 

Syed Shameerur Rahman commented on TEZ-4148:
--------------------------------------------

[~jeagles] [~rbalamohan]
I am not sure why the value was hardcoded to 1 in the first place. Any thoughts here?

> Make Number Of Tez AM Attempts Configurable When DAG Recovery Is Disabled
> -------------------------------------------------------------------------
>
>                 Key: TEZ-4148
>                 URL: https://issues.apache.org/jira/browse/TEZ-4148
>             Project: Apache Tez
>          Issue Type: Task
>            Reporter: Syed Shameerur Rahman
>            Assignee: Syed Shameerur Rahman
>            Priority: Major
>
> Currently when DAG recovery is set to false, The MaxAppAttempts is hardcoded to 1.
> {code:java}
>     // Set Tez Sessions to not retry on AM crashes if recovery is disabled
>     if (!amConfig.getTezConfiguration().getBoolean(
>             TezConfiguration.DAG_RECOVERY_ENABLED,
>             TezConfiguration.DAG_RECOVERY_ENABLED_DEFAULT)) {
>       appContext.setMaxAppAttempts(1);
>     }
> {code}
> I think it is better to keep it configurable (Even when DAG recovery is false) by remove this piece of code since the *appContext* object have already set the *setMaxAppAttempts* to *TEZ_AM_MAX_APP_ATTEMPTS*.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)