You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Wang1rrr (via GitHub)" <gi...@apache.org> on 2026/10/19 04:01:39 UTC
[PR] fix(build): preserve JAR permissions during legal packaging [rocketmq-dashboard]
Wang1rrr opened a new pull request, #7007:
URL: https://github.com/apache/rocketmq-dashboard/pull/7007
## Summary
Fixes #7006.
Copy the original JAR's file mode onto the verified temporary archive before atomic replacement. `NamedTemporaryFile` otherwise changes every POSIX artifact to owner-only `0600`, which breaks deployment under a different service account.
Add a POSIX regression covering `0644`, `0640` and `0755`, archive validation, and a second packaging pass. It uses a local temporary filesystem so Windows-mounted checkouts do not affect the result.
## Validation
`python -m unittest discover -s server/scripts -p legal_test.py` using Python 3.12 on Linux: **7 tests passed**. All three permission subcases failed before the fix, with actual mode `0600`.
The existing round-trip, payload-integrity and gate-failure tests also pass. The permission test skips on non-POSIX systems. No full Maven packaging was performed for this patch.
AI-assisted implementation; the two-file diff and regression output were reviewed before submission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(build): preserve JAR permissions during legal packaging [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #7007:
URL: https://github.com/apache/rocketmq-dashboard/pull/7007#issuecomment-6433490807
Merged as part of #6991 - squashed into `rocketmq-studio` as `8aebce7fc`.
Your change here (copy the source file mode onto the temporary file before the atomic rename, so legal packaging no longer narrows JAR permissions to owner-only) is included.
We grouped 5 of your related build and deployment fixes into a single commit so the history stays reviewable; the other PRs in the group are closed with the same note. Everything was cherry-picked onto the current baseline with you kept as the author, and your tests came along with the change.
Thanks for the consistently well-tested patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(build): preserve JAR permissions during legal packaging [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #7007: fix(build): preserve JAR permissions during legal packaging
URL: https://github.com/apache/rocketmq-dashboard/pull/7007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org