You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/09 18:23:28 UTC
[GitHub] [spark] allisonwang-db opened a new pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
allisonwang-db opened a new pull request #32111:
URL: https://github.com/apache/spark/pull/32111
### What changes were proposed in this pull request?
This PR allows non-aggregated correlated scalar subquery if the max output row is less than 2. Correlated scalar subqueries need to be aggregated because they are going to be decorrelated and rewritten as LEFT OUTER joins. If the correlated scalar subquery produces more than one output row, the rewrite will yield wrong results.
But this constraint can be relaxed when the subquery plan's the max number of output rows is less than or equal to 1.
### Why are the changes needed?
To relax a constraint in CheckAnalysis for the correlated scalar subquery.
### Does this PR introduce _any_ user-facing change?
Yes
### How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-817024431
**[Test build #137152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137152/testReport)** for PR 32111 at commit [`ac1434d`](https://github.com/apache/spark/commit/ac1434d9a4cfd6482b5a5d86480016c06d55b15a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-816873926
**[Test build #137152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137152/testReport)** for PR 32111 at commit [`ac1434d`](https://github.com/apache/spark/commit/ac1434d9a4cfd6482b5a5d86480016c06d55b15a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-818509310
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-818320451
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-816873926
**[Test build #137152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137152/testReport)** for PR 32111 at commit [`ac1434d`](https://github.com/apache/spark/commit/ac1434d9a4cfd6482b5a5d86480016c06d55b15a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-817077902
**[Test build #137156 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137156/testReport)** for PR 32111 at commit [`00d8c1b`](https://github.com/apache/spark/commit/00d8c1bef882163d948d8b72bcb44d2382b99b91).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-816919706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-816919742
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41731/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #32111:
URL: https://github.com/apache/spark/pull/32111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-817025021
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137152/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-817038951
**[Test build #137156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137156/testReport)** for PR 32111 at commit [`00d8c1b`](https://github.com/apache/spark/commit/00d8c1bef882163d948d8b72bcb44d2382b99b91).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-817081112
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137156/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-817047648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-817025021
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137152/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-817048130
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41735/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-817038951
**[Test build #137156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137156/testReport)** for PR 32111 at commit [`00d8c1b`](https://github.com/apache/spark/commit/00d8c1bef882163d948d8b72bcb44d2382b99b91).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-817048130
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41735/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-816919742
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41731/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32111: [SPARK-28379][SQL] Allow non-aggregated single row correlated scalar subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32111:
URL: https://github.com/apache/spark/pull/32111#issuecomment-817081112
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137156/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org