You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2017/02/28 22:39:26 UTC

svn commit: r1784829 - in /jmeter/trunk: extras/remote.bsh xdocs/usermanual/best-practices.xml

Author: pmouawad
Date: Tue Feb 28 22:39:25 2017
New Revision: 1784829

URL: http://svn.apache.org/viewvc?rev=1784829&view=rev
Log:
Remove log_level occurences

Modified:
    jmeter/trunk/extras/remote.bsh
    jmeter/trunk/xdocs/usermanual/best-practices.xml

Modified: jmeter/trunk/extras/remote.bsh
URL: http://svn.apache.org/viewvc/jmeter/trunk/extras/remote.bsh?rev=1784829&r1=1784828&r2=1784829&view=diff
==============================================================================
--- jmeter/trunk/extras/remote.bsh (original)
+++ jmeter/trunk/extras/remote.bsh Tue Feb 28 22:39:25 2017
@@ -34,9 +34,6 @@ print(args);
 printsysprop("user.home");
 printsysprop("user.dir");
 
-printprop("log_level.jmeter");
-printprop("log_level.jorphan");
-
 // loglevel("DEBUG","jmeter");
 
 for(i=0;i<10;i++){

Modified: jmeter/trunk/xdocs/usermanual/best-practices.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/best-practices.xml?rev=1784829&r1=1784828&r2=1784829&view=diff
==============================================================================
--- jmeter/trunk/xdocs/usermanual/best-practices.xml (original)
+++ jmeter/trunk/xdocs/usermanual/best-practices.xml Tue Feb 28 22:39:25 2017
@@ -214,8 +214,6 @@ BeanShell 2.0b5 - by Pat Niemeyer (pat@p
 bsh % remote.bsh starting
 user.home = C:\Documents and Settings\User
 user.dir = D:\eclipseworkspaces\main\JMeter_trunk\bin
-log_level.jmeter = INFO
-log_level.jorphan = INFO
 Setting property 'EXAMPLE' to '0'.
 Setting property 'EXAMPLE' to '1'.
 Setting property 'EXAMPLE' to '2'.



Re: svn commit: r1784829 - in /jmeter/trunk: extras/remote.bsh xdocs/usermanual/best-practices.xml

Posted by sebb <se...@gmail.com>.
On 28 February 2017 at 23:20, Philippe Mouawad
<ph...@gmail.com> wrote:
> On Wednesday, March 1, 2017, sebb <se...@gmail.com> wrote:
>
>> On 28 February 2017 at 22:39,  <pmouawad@apache.org <javascript:;>> wrote:
>> > Author: pmouawad
>> > Date: Tue Feb 28 22:39:25 2017
>> > New Revision: 1784829
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1784829&view=rev
>> > Log:
>> > Remove log_level occurences
>> >
>> > Modified:
>> >     jmeter/trunk/extras/remote.bsh
>> >     jmeter/trunk/xdocs/usermanual/best-practices.xml
>> >
>> > Modified: jmeter/trunk/extras/remote.bsh
>> > URL: http://svn.apache.org/viewvc/jmeter/trunk/extras/remote.
>> bsh?rev=1784829&r1=1784828&r2=1784829&view=diff
>> > ============================================================
>> ==================
>> > --- jmeter/trunk/extras/remote.bsh (original)
>> > +++ jmeter/trunk/extras/remote.bsh Tue Feb 28 22:39:25 2017
>> > @@ -34,9 +34,6 @@ print(args);
>> >  printsysprop("user.home");
>> >  printsysprop("user.dir");
>> >
>> > -printprop("log_level.jmeter");
>> > -printprop("log_level.jorphan");
>> > -
>> >  // loglevel("DEBUG","jmeter");
>>
>> This should be a clue that there's a loglevel function somewhere.
>> It needs to be found and updated to use the new style of logging.
>>
>> And the printprop calls should ideally be replaced with something that
>> displays the logging level.
>
>
> I've never ever used this feature (and we advise using groovy now) so if
> you have an good view of what needs to be fixed,  please go ahead.
> Thanks

The startup.bsh script needs to be updated to use the new logging methods.

I don't know how to do it since the documentation does not exist, and
anyway I don't see why I should be the one to fix it.

>>
>> >
>> >  for(i=0;i<10;i++){
>> >
>> > Modified: jmeter/trunk/xdocs/usermanual/best-practices.xml
>> > URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/
>> best-practices.xml?rev=1784829&r1=1784828&r2=1784829&view=diff
>> > ============================================================
>> ==================
>> > --- jmeter/trunk/xdocs/usermanual/best-practices.xml (original)
>> > +++ jmeter/trunk/xdocs/usermanual/best-practices.xml Tue Feb 28
>> 22:39:25 2017
>> > @@ -214,8 +214,6 @@ BeanShell 2.0b5 - by Pat Niemeyer (pat@p
>> >  bsh % remote.bsh starting
>> >  user.home = C:\Documents and Settings\User
>> >  user.dir = D:\eclipseworkspaces\main\JMeter_trunk\bin
>> > -log_level.jmeter = INFO
>> > -log_level.jorphan = INFO
>> >  Setting property 'EXAMPLE' to '0'.
>> >  Setting property 'EXAMPLE' to '1'.
>> >  Setting property 'EXAMPLE' to '2'.
>> >
>> >
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Re: svn commit: r1784829 - in /jmeter/trunk: extras/remote.bsh xdocs/usermanual/best-practices.xml

Posted by Philippe Mouawad <ph...@gmail.com>.
On Wednesday, March 1, 2017, sebb <se...@gmail.com> wrote:

> On 28 February 2017 at 22:39,  <pmouawad@apache.org <javascript:;>> wrote:
> > Author: pmouawad
> > Date: Tue Feb 28 22:39:25 2017
> > New Revision: 1784829
> >
> > URL: http://svn.apache.org/viewvc?rev=1784829&view=rev
> > Log:
> > Remove log_level occurences
> >
> > Modified:
> >     jmeter/trunk/extras/remote.bsh
> >     jmeter/trunk/xdocs/usermanual/best-practices.xml
> >
> > Modified: jmeter/trunk/extras/remote.bsh
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/extras/remote.
> bsh?rev=1784829&r1=1784828&r2=1784829&view=diff
> > ============================================================
> ==================
> > --- jmeter/trunk/extras/remote.bsh (original)
> > +++ jmeter/trunk/extras/remote.bsh Tue Feb 28 22:39:25 2017
> > @@ -34,9 +34,6 @@ print(args);
> >  printsysprop("user.home");
> >  printsysprop("user.dir");
> >
> > -printprop("log_level.jmeter");
> > -printprop("log_level.jorphan");
> > -
> >  // loglevel("DEBUG","jmeter");
>
> This should be a clue that there's a loglevel function somewhere.
> It needs to be found and updated to use the new style of logging.
>
> And the printprop calls should ideally be replaced with something that
> displays the logging level.


I've never ever used this feature (and we advise using groovy now) so if
you have an good view of what needs to be fixed,  please go ahead.
Thanks

>
> >
> >  for(i=0;i<10;i++){
> >
> > Modified: jmeter/trunk/xdocs/usermanual/best-practices.xml
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/
> best-practices.xml?rev=1784829&r1=1784828&r2=1784829&view=diff
> > ============================================================
> ==================
> > --- jmeter/trunk/xdocs/usermanual/best-practices.xml (original)
> > +++ jmeter/trunk/xdocs/usermanual/best-practices.xml Tue Feb 28
> 22:39:25 2017
> > @@ -214,8 +214,6 @@ BeanShell 2.0b5 - by Pat Niemeyer (pat@p
> >  bsh % remote.bsh starting
> >  user.home = C:\Documents and Settings\User
> >  user.dir = D:\eclipseworkspaces\main\JMeter_trunk\bin
> > -log_level.jmeter = INFO
> > -log_level.jorphan = INFO
> >  Setting property 'EXAMPLE' to '0'.
> >  Setting property 'EXAMPLE' to '1'.
> >  Setting property 'EXAMPLE' to '2'.
> >
> >
>


-- 
Cordialement.
Philippe Mouawad.

Re: svn commit: r1784829 - in /jmeter/trunk: extras/remote.bsh xdocs/usermanual/best-practices.xml

Posted by Woonsan Ko <wo...@apache.org>.
On Tue, Feb 28, 2017 at 6:16 PM, sebb <se...@gmail.com> wrote:
> On 28 February 2017 at 22:39,  <pm...@apache.org> wrote:
>> Author: pmouawad
>> Date: Tue Feb 28 22:39:25 2017
>> New Revision: 1784829
>>
>> URL: http://svn.apache.org/viewvc?rev=1784829&view=rev
>> Log:
>> Remove log_level occurences
>>
>> Modified:
>>     jmeter/trunk/extras/remote.bsh
>>     jmeter/trunk/xdocs/usermanual/best-practices.xml
>>
>> Modified: jmeter/trunk/extras/remote.bsh
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/extras/remote.bsh?rev=1784829&r1=1784828&r2=1784829&view=diff
>> ==============================================================================
>> --- jmeter/trunk/extras/remote.bsh (original)
>> +++ jmeter/trunk/extras/remote.bsh Tue Feb 28 22:39:25 2017
>> @@ -34,9 +34,6 @@ print(args);
>>  printsysprop("user.home");
>>  printsysprop("user.dir");
>>
>> -printprop("log_level.jmeter");
>> -printprop("log_level.jorphan");
>> -
>>  // loglevel("DEBUG","jmeter");
>
> This should be a clue that there's a loglevel function somewhere.
> It needs to be found and updated to use the new style of logging.

The new way to set log level for a category or for root is here:
- https://github.com/apache/jmeter/blob/trunk/src/core/org/apache/jmeter/JMeter.java#L830-L852

Regards,

Woonsan

>
> And the printprop calls should ideally be replaced with something that
> displays the logging level.
>
>>
>>  for(i=0;i<10;i++){
>>
>> Modified: jmeter/trunk/xdocs/usermanual/best-practices.xml
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/best-practices.xml?rev=1784829&r1=1784828&r2=1784829&view=diff
>> ==============================================================================
>> --- jmeter/trunk/xdocs/usermanual/best-practices.xml (original)
>> +++ jmeter/trunk/xdocs/usermanual/best-practices.xml Tue Feb 28 22:39:25 2017
>> @@ -214,8 +214,6 @@ BeanShell 2.0b5 - by Pat Niemeyer (pat@p
>>  bsh % remote.bsh starting
>>  user.home = C:\Documents and Settings\User
>>  user.dir = D:\eclipseworkspaces\main\JMeter_trunk\bin
>> -log_level.jmeter = INFO
>> -log_level.jorphan = INFO
>>  Setting property 'EXAMPLE' to '0'.
>>  Setting property 'EXAMPLE' to '1'.
>>  Setting property 'EXAMPLE' to '2'.
>>
>>

Re: svn commit: r1784829 - in /jmeter/trunk: extras/remote.bsh xdocs/usermanual/best-practices.xml

Posted by sebb <se...@gmail.com>.
On 28 February 2017 at 22:39,  <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Tue Feb 28 22:39:25 2017
> New Revision: 1784829
>
> URL: http://svn.apache.org/viewvc?rev=1784829&view=rev
> Log:
> Remove log_level occurences
>
> Modified:
>     jmeter/trunk/extras/remote.bsh
>     jmeter/trunk/xdocs/usermanual/best-practices.xml
>
> Modified: jmeter/trunk/extras/remote.bsh
> URL: http://svn.apache.org/viewvc/jmeter/trunk/extras/remote.bsh?rev=1784829&r1=1784828&r2=1784829&view=diff
> ==============================================================================
> --- jmeter/trunk/extras/remote.bsh (original)
> +++ jmeter/trunk/extras/remote.bsh Tue Feb 28 22:39:25 2017
> @@ -34,9 +34,6 @@ print(args);
>  printsysprop("user.home");
>  printsysprop("user.dir");
>
> -printprop("log_level.jmeter");
> -printprop("log_level.jorphan");
> -
>  // loglevel("DEBUG","jmeter");

This should be a clue that there's a loglevel function somewhere.
It needs to be found and updated to use the new style of logging.

And the printprop calls should ideally be replaced with something that
displays the logging level.

>
>  for(i=0;i<10;i++){
>
> Modified: jmeter/trunk/xdocs/usermanual/best-practices.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/best-practices.xml?rev=1784829&r1=1784828&r2=1784829&view=diff
> ==============================================================================
> --- jmeter/trunk/xdocs/usermanual/best-practices.xml (original)
> +++ jmeter/trunk/xdocs/usermanual/best-practices.xml Tue Feb 28 22:39:25 2017
> @@ -214,8 +214,6 @@ BeanShell 2.0b5 - by Pat Niemeyer (pat@p
>  bsh % remote.bsh starting
>  user.home = C:\Documents and Settings\User
>  user.dir = D:\eclipseworkspaces\main\JMeter_trunk\bin
> -log_level.jmeter = INFO
> -log_level.jorphan = INFO
>  Setting property 'EXAMPLE' to '0'.
>  Setting property 'EXAMPLE' to '1'.
>  Setting property 'EXAMPLE' to '2'.
>
>