[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9924: Check openssl version and add appropriate defines

["cmcfarlen (via GitHub)" <gi...@apache.org>]

cmcfarlen commented on code in PR #9924:
URL: https://github.com/apache/trafficserver/pull/9924#discussion_r1245395142


##########
CMakeLists.txt:
##########
@@ -167,7 +167,14 @@ endif()
 find_package(PCRE)
 
 include(FindOpenSSL)
+include(CheckOpenSSLIsBoringSSL)
 find_package(OpenSSL)
+check_openssl_is_boringssl(OPENSSL_IS_BORINGSSL "${OPENSSL_INCLUDE_DIR}")
+
+if(OPENSSL_VERSION VERSION_GREATER_EQUAL "3.0.0")
+    set(OPENSSL_IS_OPENSSL3 ON)
+    add_compile_definitions(OPENSSL_API_COMPAT=10002 OPENSSL_IS_OPENSSL3)

Review Comment:
   This is how auto tools is setup when openssl3 is found.  I'm not sure if its necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org