patch for review - refactoring related to the stateful cache and the management of timedout stateful beans

[Thiago Veronezi <th...@veronezi.org>]

Hi devs,
I just uploaded a refactoring related to the stateful cache and the
management of timedout stateful beans. It is base on the last Jarek
changes.

With this refactoring, we don't need to worry about cache cleanup interval.
Every timedout bean is remove when its timeout date is reached, even if the
bean is persisted on disk. This can save some extra loops when using
stateful beans and add the timeout feature to passivated beans. Most of the
changes are found at the SimpleCache class, but I've also added a new class
(RemoveBeanThread) and changed a little bit the StatefulContainer class.

Jarek, you are the one for this review... as you have it fresh in your mind.
Please, codereview it for me...  but anyone is welcome to review it. :O)

https://issues.apache.org/jira/browse/OPENEJB-1345

tkx a lot!
Thiago.

Re: patch for review - refactoring related to the stateful cache and the management of timedout stateful beans

[Thiago Veronezi <th...@veronezi.org>]

Ahhhh... so thats the trick... :O)
I was about to ask how to remove that... thanks... :O)
[]s,
Thiago.


On Thu, Aug 26, 2010 at 4:06 PM, Karan Malhi <ka...@gmail.com> wrote:

> A quick look shows me that there is a lot of eclipse IDE specific settings
> in the patch. There are a lot of examples projects which do not have
> .settings in their svn:ignore list.
> Easiest would be to run mvn eclipse:clean in examples and re-create the
> patch. I will leave Jarek to review the rest :)
>
> On Thu, Aug 26, 2010 at 3:50 PM, Thiago Veronezi <thiago@veronezi.org
> >wrote:
>
> > Hi devs,
> > I just uploaded a refactoring related to the stateful cache and the
> > management of timedout stateful beans. It is base on the last Jarek
> > changes.
> >
> > With this refactoring, we don't need to worry about cache cleanup
> interval.
> > Every timedout bean is remove when its timeout date is reached, even if
> the
> > bean is persisted on disk. This can save some extra loops when using
> > stateful beans and add the timeout feature to passivated beans. Most of
> the
> > changes are found at the SimpleCache class, but I've also added a new
> class
> > (RemoveBeanThread) and changed a little bit the StatefulContainer class.
> >
> > Jarek, you are the one for this review... as you have it fresh in your
> > mind.
> > Please, codereview it for me...  but anyone is welcome to review it. :O)
> >
> > https://issues.apache.org/jira/browse/OPENEJB-1345
> >
> > tkx a lot!
> > Thiago.
> >
>
>
>
> --
> Karan Singh Malhi
>

Re: patch for review - refactoring related to the stateful cache and the management of timedout stateful beans

[Karan Malhi <ka...@gmail.com>]

A quick look shows me that there is a lot of eclipse IDE specific settings
in the patch. There are a lot of examples projects which do not have
.settings in their svn:ignore list.
Easiest would be to run mvn eclipse:clean in examples and re-create the
patch. I will leave Jarek to review the rest :)

On Thu, Aug 26, 2010 at 3:50 PM, Thiago Veronezi <th...@veronezi.org>wrote:

> Hi devs,
> I just uploaded a refactoring related to the stateful cache and the
> management of timedout stateful beans. It is base on the last Jarek
> changes.
>
> With this refactoring, we don't need to worry about cache cleanup interval.
> Every timedout bean is remove when its timeout date is reached, even if the
> bean is persisted on disk. This can save some extra loops when using
> stateful beans and add the timeout feature to passivated beans. Most of the
> changes are found at the SimpleCache class, but I've also added a new class
> (RemoveBeanThread) and changed a little bit the StatefulContainer class.
>
> Jarek, you are the one for this review... as you have it fresh in your
> mind.
> Please, codereview it for me...  but anyone is welcome to review it. :O)
>
> https://issues.apache.org/jira/browse/OPENEJB-1345
>
> tkx a lot!
> Thiago.
>



-- 
Karan Singh Malhi