[GitHub] [spark] cloud-fan commented on a diff in pull request #41585: [WIP] Alternative for JoinWith

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #41585:
URL: https://github.com/apache/spark/pull/41585#discussion_r1231979178


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala:
##########
@@ -207,12 +207,18 @@ object UnresolvedTVFAliases {
 /**
  * Holds the name of an attribute that has yet to be resolved.
  */
-case class UnresolvedAttribute(nameParts: Seq[String]) extends Attribute with Unevaluable {
+case class UnresolvedAttribute(
+    nameParts: Seq[String],
+    optionalExprId: Option[ExprId])

Review Comment:
   why do we need this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org