[GitHub] [servicecomb-service-center] little-cui commented on a diff in pull request #1365: extend password

[GitBox <gi...@apache.org>]

little-cui commented on code in PR #1365:
URL: https://github.com/apache/servicecomb-service-center/pull/1365#discussion_r1045517591


##########
pkg/privacy/password.go:
##########
@@ -42,14 +53,14 @@ func HashPassword(pwd string) (string, error) {
 	}
 	return stringutil.Bytes2str(hash), nil
 }
-func ScryptPassword(pwd string) (string, error) {
+func (p *Password) ScryptPassword(pwd string) (string, error) {

Review Comment:
   不需要修改对外公开的方法，而是在方法里引用DefaultManager，这样其他地方就不需要修改，其他扩展的地方，只需要Init时替换DefaultManager即可



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org