You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Bryan Cutler (JIRA)" <ji...@apache.org> on 2016/01/08 01:01:40 UTC
[jira] [Commented] (SPARK-12701) Logging FileAppender should use
join to ensure thread is finished
[ https://issues.apache.org/jira/browse/SPARK-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088429#comment-15088429 ]
Bryan Cutler commented on SPARK-12701:
--------------------------------------
I can submit a PR for this.
> Logging FileAppender should use join to ensure thread is finished
> -----------------------------------------------------------------
>
> Key: SPARK-12701
> URL: https://issues.apache.org/jira/browse/SPARK-12701
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
> Reporter: Bryan Cutler
> Priority: Minor
>
> Currently, FileAppender for logging uses wait/notifyAll to signal that the writing thread has finished. While I was trying to write a regression test for a fix of SPARK-9844, the writing thread was not able to fully complete before the process was shutdown, despite calling {{FileAppender.awaitTermination}}. Using join ensures the thread completes and would simplify things a little more.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org