You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/18 18:07:43 UTC
[GitHub] [maven] michael-o opened a new pull request #385: [MNG-6931] Deprecate DefaultLog
michael-o opened a new pull request #385:
URL: https://github.com/apache/maven/pull/385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #385: [MNG-6931] Deprecate DefaultLog
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #385:
URL: https://github.com/apache/maven/pull/385#issuecomment-711367012
>
>
> What about deprecating also org.apache.maven.plugin.logging.Log ?
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #385: [MNG-6931] Deprecate DefaultLog
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #385:
URL: https://github.com/apache/maven/pull/385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] elharo commented on a change in pull request #385: [MNG-6931] Deprecate DefaultLog
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #385:
URL: https://github.com/apache/maven/pull/385#discussion_r507195029
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/monitor/logging/DefaultLog.java
##########
@@ -24,7 +24,10 @@
/**
* @author jdcasey
+ *
+ * @deprecated Use SFL4J directly
Review comment:
SLF4J
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java
##########
@@ -149,6 +149,10 @@
/** Plugin container context */
private Map pluginContext;
+ /**
+ * @deprecated Use SFL4J directly
Review comment:
SLF4J
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/Mojo.java
##########
@@ -54,8 +54,10 @@ void execute()
* and feedback to the user.
*
* @param log a new logger
+ *
+ * @deprecated Use SFL4J directly
Review comment:
SLF4J
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/Mojo.java
##########
@@ -64,6 +66,8 @@ void execute()
* @return a log4j-like logger object which allows plugins to create messages at levels of <code>"debug"</code>,
* <code>"info"</code>, <code>"warn"</code>, and <code>"error"</code>. This logger is the accepted means to display
Review comment:
delete "This logger...to the user."
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java
##########
@@ -167,7 +171,9 @@ public void setLog( Log log )
* method directly whenever you need the logger, it is fast enough and needs no caching.
*
* @see org.apache.maven.plugin.Mojo#getLog()
+ * @deprecated Use SFL4J directly
Review comment:
use
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java
##########
@@ -167,7 +171,9 @@ public void setLog( Log log )
* method directly whenever you need the logger, it is fast enough and needs no caching.
*
* @see org.apache.maven.plugin.Mojo#getLog()
+ * @deprecated Use SFL4J directly
Review comment:
SLF4J
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/Mojo.java
##########
@@ -64,6 +66,8 @@ void execute()
* @return a log4j-like logger object which allows plugins to create messages at levels of <code>"debug"</code>,
* <code>"info"</code>, <code>"warn"</code>, and <code>"error"</code>. This logger is the accepted means to display
* information to the user.
+ * @deprecated Use SFL4J directly
Review comment:
use SLF4J
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slachiewicz commented on pull request #385: [MNG-6931] Deprecate DefaultLog
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #385:
URL: https://github.com/apache/maven/pull/385#issuecomment-711365774
What about deprecating also org.apache.maven.plugin.logging.Log ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #385: [MNG-6931] Deprecate DefaultLog
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #385:
URL: https://github.com/apache/maven/pull/385#discussion_r507195270
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/monitor/logging/DefaultLog.java
##########
@@ -24,7 +24,10 @@
/**
* @author jdcasey
+ *
+ * @deprecated Use SFL4J directly
Review comment:
Blind me, copy and paste error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #385: [MNG-6931] Deprecate DefaultLog
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #385:
URL: https://github.com/apache/maven/pull/385#issuecomment-711366260
> Log
This perfectly makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o removed a comment on pull request #385: [MNG-6931] Deprecate DefaultLog
Posted by GitBox <gi...@apache.org>.
michael-o removed a comment on pull request #385:
URL: https://github.com/apache/maven/pull/385#issuecomment-711366260
> Log
This perfectly makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org