[GitHub] MariuszSkamra edited a comment on issue #16: Add event callbacks on command handlers

[GitBox <gi...@apache.org>]

MariuszSkamra edited a comment on issue #16: Add event callbacks on command handlers
URL: https://github.com/apache/mynewt-mcumgr/pull/16#issuecomment-436598498
 
 
   I updated PR with respect to your comments
   @rymanluk now, everytime, command will fail, MGMT_EVT_OP_CMD_DONE will be sent anyway, with error status as defined by MGMT_ERR_* defines.
   @nvlsianpu To avoid confusion, I changed statuses to opcodes MGMT_EVT_OP_CMD_* adding 3rd MGMT_EVT_OP_CMD_STATUS which argument can be status of upload. This way I avoid 0x80 shift, which might be confusing.
   @carlescufi I will create an issue for this one to keep it in mind. Note, that it is not necessary feature, and in some cases (lack of display??) percentages are not needed IMO.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services