[GitHub] [geode] dschneider-pivotal commented on issue #3438: GEODE-6621: ensure that getBucketOwners result is modifiable

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

I initially planned on adding a unit test to ProxyBucketRegionTest but it looked like ProxyBucketRegion would need to refactoring to get the advisor mockable. It uses a static method in the constructor to create the advisor and that static method is passed the partially constructed ProxyBucketRegion and uses some of its state to create the advisor. Since this is correcting a problem introduced by a refactoring that did not have tests, by undoing one of the changes, I think it is okay to not have test coverage for this pull request.

[ Full content available at: https://github.com/apache/geode/pull/3438 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org