You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jonathan Gray (JIRA)" <ji...@apache.org> on 2009/06/01 08:22:07 UTC
[jira] Created: (HBASE-1465) Remove unnecessary @Overrides
Remove unnecessary @Overrides
-----------------------------
Key: HBASE-1465
URL: https://issues.apache.org/jira/browse/HBASE-1465
Project: Hadoop HBase
Issue Type: Improvement
Affects Versions: 0.20.0
Reporter: Jonathan Gray
Assignee: Jonathan Gray
Priority: Trivial
Fix For: 0.20.0
Eclipse on my Mac is showing some errors when an @Override is used when a class implements an interface rather than extends.
Not a big deal but I want to keep this patch around anyways for personal use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1465) Remove unnecessary @Overrides
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1465:
---------------------------------
Attachment: HBASE-1465-v1.patch
Posted patch to wrong issue earlier. Simple patch that drops a few unnecessary @Overrides.
> Remove unnecessary @Overrides
> -----------------------------
>
> Key: HBASE-1465
> URL: https://issues.apache.org/jira/browse/HBASE-1465
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: HBASE-1465-v1.patch
>
>
> Eclipse on my Mac is showing some errors when an @Override is used when a class implements an interface rather than extends.
> Not a big deal but I want to keep this patch around anyways for personal use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1465) Remove unnecessary @Overrides
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1465:
-------------------------
Moving out of 0.20.0. Doesn't seem like it belongs if its just place-holder for a jgray patch.
> Remove unnecessary @Overrides
> -----------------------------
>
> Key: HBASE-1465
> URL: https://issues.apache.org/jira/browse/HBASE-1465
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: HBASE-1465-v1.patch
>
>
> Eclipse on my Mac is showing some errors when an @Override is used when a class implements an interface rather than extends.
> Not a big deal but I want to keep this patch around anyways for personal use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1465) Remove unnecessary @Overrides
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715123#action_12715123 ]
stack commented on HBASE-1465:
------------------------------
(@ddlatham: thats kinda funny that you wrote the linked-to article -- it was a random google search)
> Remove unnecessary @Overrides
> -----------------------------
>
> Key: HBASE-1465
> URL: https://issues.apache.org/jira/browse/HBASE-1465
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: HBASE-1465-v1.patch
>
>
> Eclipse on my Mac is showing some errors when an @Override is used when a class implements an interface rather than extends.
> Not a big deal but I want to keep this patch around anyways for personal use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1465) Remove unnecessary @Overrides
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1465:
---------------------------------
Attachment: HBASE-1460-v2.patch
Unit tested and so far it works as advertised. A couple more unit tests still needed to get full coverage.
> Remove unnecessary @Overrides
> -----------------------------
>
> Key: HBASE-1465
> URL: https://issues.apache.org/jira/browse/HBASE-1465
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Trivial
> Fix For: 0.20.0
>
>
> Eclipse on my Mac is showing some errors when an @Override is used when a class implements an interface rather than extends.
> Not a big deal but I want to keep this patch around anyways for personal use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1465) Remove unnecessary @Overrides
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1465:
---------------------------------
Comment: was deleted
(was: Unit tested and so far it works as advertised. A couple more unit tests still needed to get full coverage.)
> Remove unnecessary @Overrides
> -----------------------------
>
> Key: HBASE-1465
> URL: https://issues.apache.org/jira/browse/HBASE-1465
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Trivial
> Fix For: 0.20.0
>
>
> Eclipse on my Mac is showing some errors when an @Override is used when a class implements an interface rather than extends.
> Not a big deal but I want to keep this patch around anyways for personal use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1465) Remove unnecessary @Overrides
Posted by "Dave Latham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715111#action_12715111 ]
Dave Latham commented on HBASE-1465:
------------------------------------
I believe the compiler has always flagged bad @Overrides tags. I'm a fan of @Overrides, the compiler has saved me from a mistake a couple times, and it's helpful when I'm reading someone else's code because when it is used consistently, it is obvious which methods are overriding superclass methods and which are not. (Disclaimer: I'm the guy who wrote the answer that St^Ack linked to above.)
> Remove unnecessary @Overrides
> -----------------------------
>
> Key: HBASE-1465
> URL: https://issues.apache.org/jira/browse/HBASE-1465
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: HBASE-1465-v1.patch
>
>
> Eclipse on my Mac is showing some errors when an @Override is used when a class implements an interface rather than extends.
> Not a big deal but I want to keep this patch around anyways for personal use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1465) Remove unnecessary @Overrides
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray resolved HBASE-1465.
----------------------------------
Resolution: Won't Fix
Thanks for all the good info. I didn't realize things changed in java6, you were right I was using java6 but some setting was left pointed at the default java5.
I agree with that post... would be nice if there was an @Implement annotation or such rather than reusing @Override.
> Remove unnecessary @Overrides
> -----------------------------
>
> Key: HBASE-1465
> URL: https://issues.apache.org/jira/browse/HBASE-1465
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: HBASE-1465-v1.patch
>
>
> Eclipse on my Mac is showing some errors when an @Override is used when a class implements an interface rather than extends.
> Not a big deal but I want to keep this patch around anyways for personal use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1465) Remove unnecessary @Overrides
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715091#action_12715091 ]
stack commented on HBASE-1465:
------------------------------
I've always hated @override (Just ask JK) but I think its better now that it used to be in that compiler will flag when no method is being overridden (I'm probably wrong here but I have some notion that compiler didn't flag in the past -- only recently has it begun to). Still, the arguments for, to me, seem almost specious. Summarizing the benefits as listed in link here, http://stackoverflow.com/questions/94361/when-do-you-use-javas-override-annotation-and-why, "litter your code everywhere with @override to guard against rare case where parent class method changes".
> Remove unnecessary @Overrides
> -----------------------------
>
> Key: HBASE-1465
> URL: https://issues.apache.org/jira/browse/HBASE-1465
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: HBASE-1465-v1.patch
>
>
> Eclipse on my Mac is showing some errors when an @Override is used when a class implements an interface rather than extends.
> Not a big deal but I want to keep this patch around anyways for personal use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1465) Remove unnecessary @Overrides
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1465:
---------------------------------
Attachment: (was: HBASE-1460-v2.patch)
> Remove unnecessary @Overrides
> -----------------------------
>
> Key: HBASE-1465
> URL: https://issues.apache.org/jira/browse/HBASE-1465
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Trivial
> Fix For: 0.20.0
>
>
> Eclipse on my Mac is showing some errors when an @Override is used when a class implements an interface rather than extends.
> Not a big deal but I want to keep this patch around anyways for personal use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1465) Remove unnecessary @Overrides
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714994#action_12714994 ]
ryan rawson commented on HBASE-1465:
------------------------------------
Check your settings - make sure you are set to language compatibility 6.0 or higher. @override is allowed in 6 for interfaces, but not in 5.
I don't really get the point of @override however, the IDE and javadoc tools should know this without the use of annotations. The code looks better without it too imho.
> Remove unnecessary @Overrides
> -----------------------------
>
> Key: HBASE-1465
> URL: https://issues.apache.org/jira/browse/HBASE-1465
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Trivial
> Fix For: 0.20.0
>
>
> Eclipse on my Mac is showing some errors when an @Override is used when a class implements an interface rather than extends.
> Not a big deal but I want to keep this patch around anyways for personal use.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.