You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2021/09/06 07:04:31 UTC

[GitHub] [avro] martin-g commented on a change in pull request #1301: AVRO-3184: Cache Datum Type Strings in Resolve Union

martin-g commented on a change in pull request #1301:
URL: https://github.com/apache/avro/pull/1301#discussion_r702642170



##########
File path: lang/java/avro/src/main/java/org/apache/avro/generic/GenericData.java
##########
@@ -69,6 +69,16 @@
 
   private static final GenericData INSTANCE = new GenericData();
 
+  private static final Map<Class<?>, String> PRIMATIVE_DATUM_TYPES = new IdentityHashMap<>();

Review comment:
       That's true, but `java.lang.Class` does not override `#equals()`, so it inherits `Object#equals()` which uses `==`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org