You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by "IsmoLeszczynski (via GitHub)" <gi...@apache.org> on 2024/04/12 23:42:03 UTC

[PR] fix(plc4j/ads): Invalid size writing multiple tags

IsmoLeszczynski opened a new pull request, #1524:
URL: https://github.com/apache/plc4x/pull/1524

   This fixes the issue mentioned in #1433.
   
   When writing multiple tags via ADS, the IndexOffset and tag specific data type sizes were incorrect; the IndexOffset should indicate how many tags are being written instead of how many bytes, and the individual tag write sizes were pointing to the length of the data type table entry instead of the data type size from that entry. With these changes I was able to write multiple values without issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(plc4j/ads): Invalid size writing multiple tags

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz merged PR #1524:
URL: https://github.com/apache/plc4x/pull/1524


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(plc4j/ads): Invalid size writing multiple tags

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #1524:
URL: https://github.com/apache/plc4x/pull/1524#issuecomment-2053699050

   Thanks for spotting this ... I guess it would have taken me a bit to find that issue. Very much appreciated ;-)
   With your fix indeed my ManualAdsTest worked flawlessly (which now also does multi-item writes as part of the test)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org