[jira] [Comment Edited] (HADOOP-14482) Update BUILDING.txt to include the correct steps to install zstd library

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089321#comment-16089321 ] 

Allen Wittenauer edited comment on HADOOP-14482 at 7/17/17 5:21 AM:
--------------------------------------------------------------------

If HADOOP-13578 had been handled properly, the Dockerfile would have been updated at the same time.  As it is, zstd isn't getting run through CI at all.... and thus, it would have been obvious that the build process is a bit a broken.

We should probably make a custom test in yetus for Hadoop that if the CMakefiles get touched, there should be corresponding changes to BUILDING.txt and the Dockerfile . That would highlight that just throwing native code over the fence without corresponding build and docs changes is not a good practice.


was (Author: aw):
If HADOOP-13578 had been handled properly, the Dockerfile would have been updated at the same time.  As it is, zstd isn't getting run through CI at all.

> Update BUILDING.txt to include the correct steps to install zstd library
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-14482
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14482
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Wei-Chiu Chuang
>            Priority: Minor
>
> The current BUILDING.txt includes the following steps for installing zstd library:
>     $ sudo apt-get install zstd
> This is incorrect. On my Ubuntu 16 machine, zstd is not a library
> {quote}
> apt-cache search zstd
> libzstd-dev - fast lossless compression algorithm -- development files
> libzstd0 - fast lossless compression algorithm
> zstd - fast lossless compression algorithm -- CLI tool
> {quote}
> On a Ubuntu 14 machine, I couldn't even find anything related to zstd.
> In fact, to build Hadoop with ZStandard library, I have to install libzstd-dev.
> I will also need to install the runtime to use it. libzstd0 is the older version. libzstd1 is for zstd 1.x. It's not clear to me if libzstd0 is compatible. CentOS does have libzstd1 though.
> Perhaps we can provide instruction to compile/install libzstd from source code.
> {quote}
>   * Use -Dzstd.prefix to specify a nonstandard location for the libzstd
>     header files and library files. You do not need this option if you have
>     installed zstandard using a package manager.
>   * Use -Dzstd.lib to specify a nonstandard location for the libzstd library
>     files.  Similarly to zstd.prefix, you do not need this option if you have
>     installed using a package manager.
> {quote}
> At least for CentOS, the library installed by rpm was not located and I had to specify -Dzstd.prefix to get it installed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org