$Id$

[Robert Muir <rc...@gmail.com>]

Hello, I am wondering why we are using $Id$ in solr?

To me it only seems this causes problems with applying patches (it is
causing Mark a problem right now).

I am trying to see how it is helpful? there are other ways to see the svn
history that do not cause problems with patches

-- 
Robert Muir
rcmuir@gmail.com

Re: $Id$

[Chris Hostetter <ho...@fucit.org>]

: I agree. It causes problems with patches and I don't see the benefit of
: using them in class javadocs. Though they are sometimes useful in the

The theory (historicly) has been that having CVS (or SVN) vars in the 
javadocs makes it easy to understand what version of hte class you are 
looking at when reading the docs ... but putting svnversion info in the 
javadoc header is probably better in general

: statistics section (for SolrInfoMBean)

yeah ... i'd prefer to leave them in the MBean methods ... that doesn't 
tend to cause problems with patches anyway.



-Hoss

Re: $Id$

[Shalin Shekhar Mangar <sh...@gmail.com>]

On Sun, Dec 20, 2009 at 10:42 PM, Mark Miller <ma...@gmail.com> wrote:

> Robert Muir wrote:
> > Hello, I am wondering why we are using $Id$ in solr?
> >
> > To me it only seems this causes problems with applying patches (it is
> > causing Mark a problem right now).
> >
> > I am trying to see how it is helpful? there are other ways to see the svn
> > history that do not cause problems with patches
> >
> >
> +1 on giving them the boot - we decided the same thing in Lucene - who
> needs them when they cause these problems and offer little to nothing in
> return. And I can't count how many patches I've had to hand fix ...
>
>
I agree. It causes problems with patches and I don't see the benefit of
using them in class javadocs. Though they are sometimes useful in the
statistics section (for SolrInfoMBean)

-- 
Regards,
Shalin Shekhar Mangar.

Re: $Id$

[Mark Miller <ma...@gmail.com>]

Robert Muir wrote:
> Hello, I am wondering why we are using $Id$ in solr?
>
> To me it only seems this causes problems with applying patches (it is
> causing Mark a problem right now).
>
> I am trying to see how it is helpful? there are other ways to see the svn
> history that do not cause problems with patches
>
>   
+1 on giving them the boot - we decided the same thing in Lucene - who
needs them when they cause these problems and offer little to nothing in
return. And I can't count how many patches I've had to hand fix ...

-- 
- Mark

http://www.lucidimagination.com