[GitHub] FineAndDandy commented on a change in pull request #981: Add logging for slow file permits requests. (#978)

[GitBox <gi...@apache.org>]

FineAndDandy commented on a change in pull request #981: Add logging for slow file permits requests. (#978)
URL: https://github.com/apache/accumulo/pull/981#discussion_r259794896
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java
 ##########
 @@ -287,7 +290,15 @@ private void closeReaders(Collection<FileSKVIterator> filesToClose) {
     Map<FileSKVIterator,String> readersReserved = new HashMap<>();
 
     if (!tablet.isMeta()) {
+      long start = System.currentTimeMillis();
       filePermits.acquireUninterruptibly(files.size());
 
 Review comment:
   I initially implemented it that way, but the code bloat was a bit larger than that. tryAcquire returns false after the timeout so a while loop has to be used, time has to be aggregated over all the loops, and interrupts have to be handled. Due to the time aggregating I found myself using a start/stop time in addition to the timeout time for total wait time anyway. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services