You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/25 12:34:19 UTC

[GitHub] [flink] zhuxiaoshang opened a new pull request #13240: [FLINK-19050][Documentation]

zhuxiaoshang opened a new pull request #13240:
URL: https://github.com/apache/flink/pull/13240


   ## What is the purpose of the change
   
   fix mistake of java doc of decimal presision constants definition in PostgresDialect.java#L43 
   
   
   
   ## Brief change log
   
   -fix mistake of java doc of decimal presision constants definition in PostgresDialect.java#L43 
   
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuxiaoshang commented on pull request #13240: [FLINK-19050][Documentation]

Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on pull request #13240:
URL: https://github.com/apache/flink/pull/13240#issuecomment-679998936


   cc @wuchong  plz hava a review


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] libenchao closed pull request #13240: [FLINK-19050][Documentation]Doc of MAX_DECIMAL_PRECISION should be DECIMAL

Posted by GitBox <gi...@apache.org>.
libenchao closed pull request #13240:
URL: https://github.com/apache/flink/pull/13240


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] libenchao commented on pull request #13240: [FLINK-19050][Documentation]Doc of MAX_DECIMAL_PRECISION should be DECIMAL

Posted by GitBox <gi...@apache.org>.
libenchao commented on pull request #13240:
URL: https://github.com/apache/flink/pull/13240#issuecomment-682494923


   @zhuxiaoshang Thanks for for your contribution, the change LGTM, will merge.
   
   Tips:
   - For such minor changes, we can raise a hotfix PR without a jira issue.
   - We suggest to reach an consensus in the jira issue firstly, before opening the PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13240: [FLINK-19050][Documentation]

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13240:
URL: https://github.com/apache/flink/pull/13240#issuecomment-680007217


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "11e18bf9587cfcc3a948ead892c826114a03bb4c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "11e18bf9587cfcc3a948ead892c826114a03bb4c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 11e18bf9587cfcc3a948ead892c826114a03bb4c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13240: [FLINK-19050][Documentation]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13240:
URL: https://github.com/apache/flink/pull/13240#issuecomment-680007217


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "11e18bf9587cfcc3a948ead892c826114a03bb4c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5857",
       "triggerID" : "11e18bf9587cfcc3a948ead892c826114a03bb4c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 11e18bf9587cfcc3a948ead892c826114a03bb4c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5857) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13240: [FLINK-19050][Documentation]

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13240:
URL: https://github.com/apache/flink/pull/13240#issuecomment-679998504


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 11e18bf9587cfcc3a948ead892c826114a03bb4c (Tue Aug 25 12:37:35 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19050).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuxiaoshang commented on pull request #13240: [FLINK-19050][Documentation]Doc of MAX_DECIMAL_PRECISION should be DECIMAL

Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on pull request #13240:
URL: https://github.com/apache/flink/pull/13240#issuecomment-681912255


   @JingsongLi @libenchao could plz have a review?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13240: [FLINK-19050][Documentation]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13240:
URL: https://github.com/apache/flink/pull/13240#issuecomment-680007217


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "11e18bf9587cfcc3a948ead892c826114a03bb4c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5857",
       "triggerID" : "11e18bf9587cfcc3a948ead892c826114a03bb4c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 11e18bf9587cfcc3a948ead892c826114a03bb4c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5857) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org