[GitHub] [spark] mridulm commented on a diff in pull request #42904: [SPARK-45151][CORE][UI] Task Level Thread Dump Support

["mridulm (via GitHub)" <gi...@apache.org>]

mridulm commented on code in PR #42904:
URL: https://github.com/apache/spark/pull/42904#discussion_r1325321480


##########
core/src/main/scala/org/apache/spark/scheduler/SchedulerBackend.scala:
##########
@@ -53,6 +54,8 @@ private[spark] trait SchedulerBackend {
       reason: String): Unit =
     throw new UnsupportedOperationException
 
+  def getTaskThreadDump(taskId: Long, executorId: String): Option[ThreadStackTrace]

Review Comment:
   Do we want to specify a timeout here (and propagate it) ? In case executor is severely loaded.
   This is currently not being done for executor thread dumps as well though ...



##########
core/src/main/resources/org/apache/spark/ui/static/stagepage.js:
##########
@@ -849,7 +856,18 @@ $(document).ready(function () {
             {data: "partitionId", name: "Index"},
             {data : "taskId", name: "ID"},
             {data : "attempt", name: "Attempt"},
-            {data : "status", name: "Status"},
+            {
+              data : (row, _ignored_type) => {
+                if (taskThreadDumpEnabled && row.status === "RUNNING") {

Review Comment:
   To confirm, this will show up only in live UI (due to `StagesTab,threadDumpEnabled`), right ?.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org