You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/05/29 14:31:57 UTC
svn commit: r1832450 -
/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java
Author: ggregory
Date: Tue May 29 14:31:57 2018
New Revision: 1832450
URL: http://svn.apache.org/viewvc?rev=1832450&view=rev
Log:
[CODEC-246] ColognePhoneticTest.testIsEncodeEquals missing assertions.
Modified:
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java?rev=1832450&r1=1832449&r2=1832450&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java Tue May 29 14:31:57 2018
@@ -19,6 +19,7 @@ package org.apache.commons.codec.languag
import org.apache.commons.codec.EncoderException;
import org.apache.commons.codec.StringEncoderAbstractTest;
+import org.junit.Assert;
import org.junit.Test;
/**
@@ -142,7 +143,10 @@ public class ColognePhoneticTest extends
{"ganz", "G\u00e4nse"}, // Gänse
{"Miyagi", "Miyako"}};
for (final String[] element : data) {
- this.getStringEncoder().isEncodeEqual(element[1], element[0]);
+ // This just compares and only shows we do not blow up
+ final boolean encodeEqual = this.getStringEncoder().isEncodeEqual(element[1], element[0]);
+ // Fails for https://issues.apache.org/jira/browse/CODEC-246
+ // Assert.assertTrue(element[1] + " != " + element[0], encodeEqual);
}
}