You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2016/11/29 18:53:42 UTC
Review Request 54170: RangerResourceMatcher for Hdfs and Yarn
resources does
not correctly handle policy containing only one resource whose value is "*"
- Part 2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54170/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj and Ramesh Mani.
Bugs: RANGER-1229
https://issues.apache.org/jira/browse/RANGER-1229
Repository: ranger
Description
-------
This patch fixes regression introduced in the previous patch for RANGER-1229. Adds new unit tests to test functionality broken by previous patch. Specifically, if the policy's resource-specification contain multiple values one of which is "*" then the "*" was ignored when building evaluator for the policy.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 67353ca
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 5f61bd8
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java c8f67d2
agents-common/src/test/resources/policyengine/test_policyengine_hbase_multiple_matching_policies.json PRE-CREATION
Diff: https://reviews.apache.org/r/54170/diff/
Testing
-------
Ran unit tests successfully.
Thanks,
Abhay Kulkarni
Re: Review Request 54170: RangerResourceMatcher for Hdfs and Yarn
resources
does not correctly handle policy containing only one resource whose value
is "*" - Part 2
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54170/#review157311
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On Nov. 29, 2016, 6:53 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54170/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 6:53 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
>
>
> Bugs: RANGER-1229
> https://issues.apache.org/jira/browse/RANGER-1229
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This patch fixes regression introduced in the previous patch for RANGER-1229. Adds new unit tests to test functionality broken by previous patch. Specifically, if the policy's resource-specification contain multiple values one of which is "*" then the "*" was ignored when building evaluator for the policy.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 67353ca
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 5f61bd8
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java c8f67d2
> agents-common/src/test/resources/policyengine/test_policyengine_hbase_multiple_matching_policies.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54170/diff/
>
>
> Testing
> -------
>
> Ran unit tests successfully.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>