[jira] [Work logged] (HDFS-16616) Remove the use if Sets#newHashSet and Sets#newTreeSet

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-16616?focusedWorklogId=778344&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778344 ]

ASF GitHub Bot logged work on HDFS-16616:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jun/22 22:16
            Start Date: 03/Jun/22 22:16
    Worklog Time Spent: 10m 
      Work Description: Samrat002 opened a new pull request, #4400:
URL: https://github.com/apache/hadoop/pull/4400

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   https://issues.apache.org/jira/browse/HDFS-16616
   
   ### How was this patch tested?
   
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 778344)
    Remaining Estimate: 0h
            Time Spent: 10m

> Remove the use if Sets#newHashSet and Sets#newTreeSet 
> ------------------------------------------------------
>
>                 Key: HDFS-16616
>                 URL: https://issues.apache.org/jira/browse/HDFS-16616
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: Samrat Deb
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> As part of removing guava dependencies  HADOOP-17115, HADOOP-17721, HADOOP-17722 and HADOOP-17720 are fixed,
> Currently the code call util function to create HashSet and TreeSet in the repo . These function calls dont have much importance as it is calling internally new HashSet<> / new TreeSet<> from java.utils 
> This task is to clean up all the function calls to create sets which is redundant 
> Before moving to java8 , sets were created using guava functions and API , now since this is moved away and util code in the hadoop now looks like
> 1. 
> public static <E extends Comparable> TreeSet<E> newTreeSet() {  return new TreeSet<E>(); 
> 2. 
> public static <E> HashSet<E> newHashSet()
> { return new HashSet(); }
> These interfaces dont do anything much just a extra layer of function call 
> please refer to the task 
> https://issues.apache.org/jira/browse/HADOOP-17726
> Can anyone review if this ticket add some value in the code. 
> Looking forward to some input/ thoughts . If not adding any value we can close it and not move forward with changes !



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org