You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mohammad Islam <mi...@yahoo.com> on 2012/11/14 09:57:51 UTC

Review Request: OOZIE-1068 Metadata Accessor service for HCatalog

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8051/
-----------------------------------------------------------

Review request for oozie.


Description
-------

Provide Metadata accessor service and meta data client wrapper.


This addresses bug OOZIE-1068.
    https://issues.apache.org/jira/browse/OOZIE-1068


Diffs
-----

  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/ErrorCode.java 1408939 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/hcat/MetaDataClientWrapper.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetaDataAccessorException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetaDataAccessorService.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/hcat/TestMetaDataClientWrapper.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestMetaDataAccessorService.java PRE-CREATION 

Diff: https://reviews.apache.org/r/8051/diff/


Testing
-------


Thanks,

Mohammad Islam

Re: Review Request: OOZIE-1068 Metadata Accessor service for HCatalog

Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8051/#review13610
-----------------------------------------------------------


looks good to me. minor comments. +1. Thanks Mohammad!


http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/hcat/MetaDataClientWrapper.java
<https://reviews.apache.org/r/8051/#comment29184>

    Not sure whether it is essential to throw exception when some partition(s) are not found. there can instead be a log warning indicating this



http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/hcat/TestMetaDataClientWrapper.java
<https://reviews.apache.org/r/8051/#comment29182>

    Remove the debugging string AAAA


- Mona Chitnis


On Nov. 15, 2012, 2:09 a.m., Mohammad Islam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8051/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2012, 2:09 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> Provide Metadata accessor service and meta data client wrapper.
> 
> 
> This addresses bug OOZIE-1068.
>     https://issues.apache.org/jira/browse/OOZIE-1068
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml 1408939 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/ErrorCode.java 1408939 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/hcat/MetaDataClientWrapper.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetaDataAccessorException.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetaDataAccessorService.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/hcat/TestMetaDataClientWrapper.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestMetaDataAccessorService.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1408939 
> 
> Diff: https://reviews.apache.org/r/8051/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mohammad Islam
> 
>

Re: Review Request: OOZIE-1068 Metadata Accessor service for HCatalog

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8051/
-----------------------------------------------------------

(Updated Nov. 15, 2012, 2:09 a.m.)


Review request for oozie.


Changes
-------

Updated with modified pom file.


Description
-------

Provide Metadata accessor service and meta data client wrapper.


This addresses bug OOZIE-1068.
    https://issues.apache.org/jira/browse/OOZIE-1068


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml 1408939 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/ErrorCode.java 1408939 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/hcat/MetaDataClientWrapper.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetaDataAccessorException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetaDataAccessorService.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/hcat/TestMetaDataClientWrapper.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestMetaDataAccessorService.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1408939 

Diff: https://reviews.apache.org/r/8051/diff/


Testing
-------


Thanks,

Mohammad Islam