You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by "Lance Frohman (JIRA)" <de...@myfaces.apache.org> on 2006/09/06 23:17:22 UTC

[jira] Created: (TOMAHAWK-659) add colspan attribute to tomahawk PanelGrid / PanelGroup

add colspan attribute to tomahawk PanelGrid / PanelGroup
--------------------------------------------------------

                 Key: TOMAHAWK-659
                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-659
             Project: MyFaces Tomahawk
          Issue Type: Improvement
          Components: New Component
    Affects Versions: 1.1.5-SNAPSHOT
            Reporter: Lance Frohman
         Assigned To: Lance Frohman
            Priority: Minor
             Fix For: 1.1.5-SNAPSHOT


I am adding the html colspan attribute to tomahawk PanelGroup and having tomahawk PanelGrid check for it.
This allows developers to add    colspan="n"    to <t:panelGroup> inside <t:panelGrid>.
Note - I did not add a HtmlPanelGroup.xml file for the code generator - it looks like noone is doing this for
Tomahawk components.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

RE: JIRA TOMAHAWK-659

Posted by L Frohman <lf...@gmail.com>.

Thanks Martin. 

-----Original Message-----
From: Martin Marinschek [mailto:martin.marinschek@gmail.com] 
Sent: Thursday, September 07, 2006 4:34 AM
To: MyFaces Development
Subject: Re: JIRA TOMAHAWK-659

Looks all very good to me!

regards,

Martin

On 9/7/06, L Frohman <lf...@gmail.com> wrote:
> Could someone take a quick look at this before I commit it?
> Just to make sure I am not doing anything that isn't kosher.
>
> Thanks,
> Lance
>
>
>


-- 

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

Re: JIRA TOMAHAWK-659

Posted by Martin Marinschek <ma...@gmail.com>.

Looks all very good to me!

regards,

Martin

On 9/7/06, L Frohman <lf...@gmail.com> wrote:
> Could someone take a quick look at this before I commit it?
> Just to make sure I am not doing anything that isn't kosher.
>
> Thanks,
> Lance
>
>
>


-- 

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

[jira] Resolved: (TOMAHAWK-659) add colspan attribute to tomahawk PanelGrid / PanelGroup

Posted by "Lance Frohman (JIRA)" <de...@myfaces.apache.org>.

     [ http://issues.apache.org/jira/browse/TOMAHAWK-659?page=all ]

Lance Frohman resolved TOMAHAWK-659.
------------------------------------

    Resolution: Fixed

fix committed


> add colspan attribute to tomahawk PanelGrid / PanelGroup
> --------------------------------------------------------
>
>                 Key: TOMAHAWK-659
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-659
>             Project: MyFaces Tomahawk
>          Issue Type: Improvement
>          Components: New Component
>    Affects Versions: 1.1.5-SNAPSHOT
>            Reporter: Lance Frohman
>         Assigned To: Lance Frohman
>            Priority: Minor
>             Fix For: 1.1.5-SNAPSHOT
>
>         Attachments: colspan.jsp.patch, HtmlGridRenderer.java.patch, HtmlGridRendererBase.java.patch, HtmlPanelGroup.java.patch, HtmlPanelGroupTag.java.patch, tomahawk.tld.patch, tomahawk_panel_group_attributes.xml.patch
>
>
> I am adding the html colspan attribute to tomahawk PanelGroup and having tomahawk PanelGrid check for it.
> This allows developers to add    colspan="n"    to <t:panelGroup> inside <t:panelGrid>.
> Note - I did not add a HtmlPanelGroup.xml file for the code generator - it looks like noone is doing this for
> Tomahawk components.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA TOMAHAWK-659

Posted by L Frohman <lf...@gmail.com>.

Could someone take a quick look at this before I commit it?
Just to make sure I am not doing anything that isn't kosher.

Thanks,
Lance