You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "adamreeve (via GitHub)" <gi...@apache.org> on 2023/02/26 20:40:53 UTC
[GitHub] [arrow] adamreeve commented on a diff in pull request #33893: GH-32240: [C#] Add new Apache.Arrow.Compression package to implement IPC decompression
adamreeve commented on code in PR #33893:
URL: https://github.com/apache/arrow/pull/33893#discussion_r1118148887
##########
csharp/src/Apache.Arrow.Compression/Apache.Arrow.Compression.csproj:
##########
@@ -0,0 +1,17 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <PropertyGroup>
+ <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
+ </PropertyGroup>
+
+ <ItemGroup>
+ <PackageReference Include="CommunityToolkit.HighPerformance" Version="8.0.0" />
Review Comment:
The two libraries actually implement different formats. The `K4os.Compression.LZ4.Streams` library implements the LZ4 frame format, and the `K4os.Compression.LZ4` library implements the LZ4 block format. Arrow IPC uses the frame format (https://github.com/apache/arrow/blob/apache-arrow-11.0.0/format/Message.fbs#L46-L48), so we need to use the streams library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org