[GitHub] [arrow-datafusion] jonahgao commented on issue #7078: CI failing on master: External error: query is expected to fail, but actually succeed:

["jonahgao (via GitHub)" <gi...@apache.org>]

jonahgao commented on issue #7078:
URL: https://github.com/apache/arrow-datafusion/issues/7078#issuecomment-1649209664

   > That's so weird. Do you have understanding of why sqllogictest 0.15.1 breaks these tests?
   
   I think sqllogictest is right.
   
   Some test records should be successfully executed, but they are erroneously declared as `statement error`.
   For example:
   https://github.com/apache/arrow-datafusion/blob/1a0542acbc01e5243471ae0fc3586c2f1f40013b/datafusion/core/tests/sqllogictests/test_files/aggregate.slt#L98-L100
   This seems to have already been fixed by #6734.
      
   
       
   
   I attempted to fix it but got blocked by the following record:
   https://github.com/apache/arrow-datafusion/blob/1a0542acbc01e5243471ae0fc3586c2f1f40013b/datafusion/core/tests/sqllogictests/test_files/timestamps.slt#L1252-L1254
   In the current version of Datafusion, this query can be executed successfully, but I think it should not be allowed to succeed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org