You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/29 09:13:16 UTC
[GitHub] [beam] je-ik opened a new pull request, #17504: [WIP[BEAM-14196] add test verifying output watermark propagation in bundle
je-ik opened a new pull request, #17504:
URL: https://github.com/apache/beam/pull/17504
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113182308
Run Java Spark v3 PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1117168929
@ibzib I think it would be good to get this to 2.39.0 which is cut today, would you like to have a look? Or could you recommend someone? Maybe @reuvenlax?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113181659
Run Java Dataflow V2 ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113181811
Run Samza ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113100100
Run Java Dataflow V2 ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113100952
Run Twister2 ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1114817690
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1155791353
Sorry, there is missing link to the discussion thread. The test is meant to verify output watermark is correctly hold for elements (potentially) buffered between @startbundle and @finishbundle. Producing late elements originally arriving as on time is a correctness bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113098844
Run Direct ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1155779483
The test title and the PR description says "tests that it is correct" but does not describe _what_ correctness should be or what the problem is. I noticed this test failing in some cases and I would like to be able to know if it is a bug or an unsupported feature. Can you describe what property this test is for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1115108943
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1116096980
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113097326
Run Java Samza PortableValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113182432
Run Java Spark v2 PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113182168
Run Dataflow ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1116081639
Run Flink ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113181530
Run Twister2 ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1114983216
Run Python_PVR_Flink PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113096875
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1116079328
Run Flink ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1116079534
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1114578907
Run Samza ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1114579122
Run Java Samza PortableValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1116081771
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113100646
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113182012
Run Flink ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1159037664
It was Dataflow; I noticed that the test is disabled in our internal ValidatesRunner test suite (we just re-run the same as external but using Google's build system too). But now I see it is not explicitly sickbayed externally, so it is probably excluded due to limitations in TestStream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113182646
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113182775
Run Java Samza PortableValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113180430
Retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1114982617
Run Java_PVR_Flink_Docker PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1116147147
Run Java_PVR_Flink_Docker PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1158663527
Which runner does the test fail on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113098047
Run Java Spark v3 PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113097723
Run Java Spark v2 PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113099578
Run Samza ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113181400
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik merged pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik merged PR #17504:
URL: https://github.com/apache/beam/pull/17504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1114980631
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1114817899
Run Flink ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1114818032
R: @dmvk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1116097597
Run Java_Examples_Dataflow_Java11 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1116095860
Run Python_PVR_Flink PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113098596
Run Dataflow ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #17504: [WIP] [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
je-ik commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1113099408
Run Flink ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #17504: [BEAM-14196] add test verifying output watermark propagation in bundle
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #17504:
URL: https://github.com/apache/beam/pull/17504#issuecomment-1156648738
Got it. Definitely agree: producing late elements originally arriving as one time is a correctness bug. It is troubling that we see this test failing in some places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org