You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by deepaks4077 <gi...@git.apache.org> on 2018/07/09 19:57:27 UTC
[GitHub] flink pull request #6289: [FLINK-9380]: Modified end to end test runner scri...
GitHub user deepaks4077 opened a pull request:
https://github.com/apache/flink/pull/6289
[FLINK-9380]: Modified end to end test runner script to stop deleting logs if tests fail
## What is the purpose of the change
This pull request modifies a couple of end to end test runner scripts to save logs of failed tests. Currently, logs are deleted irrespective of a test's result, making it difficult to debug failed tests.
## Brief change log
- *Modified EXIT trap to only cleanup the process instead of cleaning up logs as well*
- *Added SIGINT trap to clean up everything on test process interrupt*
- *Export TEST_DATA_DIR inside test-runner-common.sh _instead of common.sh_. This allows all test scripts to inherit this variable instead of generating it again on their own via common.sh*
- *Split operations inside cleanup() into cleanup_proc() and cleanup_files()*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/deepaks4077/flink FLINK-9380
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6289.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6289
----
commit 81d5757c1036d1a9172dc56963a4169003fa74e8
Author: Deepak Sharnma <de...@...>
Date: 2018-07-09T19:37:58Z
[FLINK-9380]: Modified test runner script to stop deleting logs if tests fail
----
---
[GitHub] flink issue #6289: [FLINK-9380]: Modified end to end test runner script to s...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6289
I'll just fix the name while merging.
---
[GitHub] flink pull request #6289: [FLINK-9380]: Modified end to end test runner scri...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6289
---
[GitHub] flink pull request #6289: [FLINK-9380]: Modified end to end test runner scri...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6289#discussion_r202631900
--- Diff: flink-end-to-end-tests/test-scripts/test-runner-common.sh ---
@@ -58,20 +63,32 @@ function run_test {
fi
fi
- if [[ ${exit_code} != 0 ]]; then
+ if [[ ${exit_code} == 0 ]]; then
+ cleanup
+ else
exit "${exit_code}"
fi
}
-# Shuts down the cluster and cleans up all temporary folders and files. Make sure to clean up even in case of failures.
+# Shuts down cluster and reverts changes to cluster configs
+function cleanup_proc {
+ shutdown_all
+ revert_default_config
+}
+
+# Cleans up all temporary folders and files
+function cleanup_files {
--- End diff --
function name is too generic, rename to `cleanup_temp_files`
---