[GitHub] [pinot] saurabhd336 commented on a diff in pull request #10687: Implement mutable index using index SPI

["saurabhd336 (via GitHub)" <gi...@apache.org>]

saurabhd336 commented on code in PR #10687:
URL: https://github.com/apache/pinot/pull/10687#discussion_r1180297536


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/inverted/InvertedIndexType.java:
##########
@@ -193,4 +196,16 @@ public InvertedIndexReader createSkippingForward(SegmentDirectory.Reader segment
   protected void handleIndexSpecificCleanup(TableConfig tableConfig) {
     tableConfig.getIndexingConfig().setInvertedIndexColumns(null);
   }
+
+  @Nullable
+  @Override
+  public MutableIndex createMutableIndex(MutableIndexContext context, IndexConfig config) {
+    if (config.isDisabled()) {
+      return null;
+    }
+    if (!context.hasDictionary()) {
+      return null;

Review Comment:
   Shouldn't we be throwing IllegalStateException here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org