You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/05 13:45:39 UTC

[GitHub] [incubator-doris] morningman commented on a change in pull request #7017: [refactor] set `forward_to_master` true by default

morningman commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743673756



##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -426,7 +426,10 @@ public long getAvailableBeForTask(long previoudBeId, String clusterName) throws
             // 1. Find if the given BE id has available slots
             if (previoudBeId != -1L) {
                 int idleTaskNum = 0;
-                if (beIdToConcurrentTasks.containsKey(previoudBeId)) {
+                if (beIdToMaxConcurrentTasks.containsKey(previoudBeId)) {
+                    idleTaskNum = 0;
+                    LOG.warn("backend:" + previoudBeId + " not found, cannot get idleTaskNum.");

Review comment:
       No need to print warn log here because this is not a root cause.
   The root cause is because BE is down. And `beIdToMaxConcurrentTasks` only contains alive Backends.
   So here we can just check if `beIdToMaxConcurrentTasks.containsKey(previoudBeId)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org