You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/14 12:49:21 UTC
[GitHub] [incubator-pekko-http] mdedetrich opened a new pull request, #48: Replace Akka with Pekko for classes and functions
mdedetrich opened a new pull request, #48:
URL: https://github.com/apache/incubator-pekko-http/pull/48
Self explanatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #48: Replace Akka with Pekko for classes and functions
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #48:
URL: https://github.com/apache/incubator-pekko-http/pull/48#issuecomment-1429720361
@jrudolph You happy with me merging this now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] spangaer commented on a diff in pull request #48: Replace Akka with Pekko for classes and functions
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on code in PR #48:
URL: https://github.com/apache/incubator-pekko-http/pull/48#discussion_r1106326484
##########
docs/src/test/java/docs/http/javadsl/server/PekkoHttp1020MigrationExample.java:
##########
@@ -13,7 +13,7 @@
import org.apache.pekko.stream.Materializer;
@SuppressWarnings("deprecation")
-public class AkkaHttp1020MigrationExample {
+public class PekkoHttp1020MigrationExample {
Review Comment:
Just accidentally stumbled over this, but seems like this one would correctly be named Akka, as there is no Pekko 10.2 Migration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph merged pull request #48: Replace Akka with Pekko for classes and functions
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph merged PR #48:
URL: https://github.com/apache/incubator-pekko-http/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #48: Replace Akka with Pekko for classes and functions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #48:
URL: https://github.com/apache/incubator-pekko-http/pull/48#discussion_r1106332152
##########
docs/src/test/java/docs/http/javadsl/server/PekkoHttp1020MigrationExample.java:
##########
@@ -13,7 +13,7 @@
import org.apache.pekko.stream.Materializer;
@SuppressWarnings("deprecation")
-public class AkkaHttp1020MigrationExample {
+public class PekkoHttp1020MigrationExample {
Review Comment:
I vote for keeping the new name - it easier to explain all the names now have Pekko in them - as opposed to explaining on a case by case basis. One extra option is to just to remove this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #48: Replace Akka with Pekko for classes and functions
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #48:
URL: https://github.com/apache/incubator-pekko-http/pull/48#discussion_r1106847324
##########
docs/src/test/java/docs/http/javadsl/server/PekkoHttp1020MigrationExample.java:
##########
@@ -13,7 +13,7 @@
import org.apache.pekko.stream.Materializer;
@SuppressWarnings("deprecation")
-public class AkkaHttp1020MigrationExample {
+public class PekkoHttp1020MigrationExample {
Review Comment:
Its likely these will be removed as they don't make sense in Pekko, but trademarks (and other legal matters) generally takes precedence over other matters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] spangaer commented on a diff in pull request #48: Replace Akka with Pekko for classes and functions
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on code in PR #48:
URL: https://github.com/apache/incubator-pekko-http/pull/48#discussion_r1106760382
##########
docs/src/test/java/docs/http/javadsl/server/PekkoHttp1020MigrationExample.java:
##########
@@ -13,7 +13,7 @@
import org.apache.pekko.stream.Materializer;
@SuppressWarnings("deprecation")
-public class AkkaHttp1020MigrationExample {
+public class PekkoHttp1020MigrationExample {
Review Comment:
I don't have any firm opinion, but unfirmly: removing it seems like the most right option then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org