You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "danielappiagyei-bc (via GitHub)" <gi...@apache.org> on 2023/11/20 19:23:27 UTC
[I] Feature Request: Make C-header files compatible with C++ [nuttx]
danielappiagyei-bc opened a new issue, #11230:
URL: https://github.com/apache/nuttx/issues/11230
Hi,
In a previous email thread, @xiaoxiang781216, @pkarashchenko, and I discussed making C header files compatible with c++. This is necessary so a C++ application can `#include` C headers w/o compilation issues. See this PR where I wanted to include some segger RTTI files in my c++ app and had to rename some c++ identifiers.
The conclusion was this:
> We can add a simple test like this:
> 1. Create a context target in Makefile to generate a .cxx file which
list and include all header files in nuttx/include
> 2. Add the generated file to CXXSRCS
> If we just want to ensure the public nuttx header files are compatible with
c++ syntax.
I can make the changes to make the header files c++-compatible. I just want to document the feature request here for posterity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Feature Request: Make C-header files compatible with C++ [nuttx]
Posted by "danielappiagyei-bc (via GitHub)" <gi...@apache.org>.
danielappiagyei-bc commented on issue #11230:
URL: https://github.com/apache/nuttx/issues/11230#issuecomment-1824869977
> @danielappiagyei-bc Yes, this is a good idea! Also, when you open the PR please point to this issue to have a cross link
Thanks Alan, will do. Should I break up these changes into multiple PRs so that it doesn't end up being a huge one with (potentially) hundreds of files changed that make it hard to review? Not sure what our GitHub philosophy is :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Feature Request: Make C-header files compatible with C++ [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on issue #11230:
URL: https://github.com/apache/nuttx/issues/11230#issuecomment-1823590312
@danielappiagyei-bc Yes, this is a good idea! Also, when you open the PR please point to this issue to have a cross link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Feature Request: Make C-header files compatible with C++ [nuttx]
Posted by "danielappiagyei-bc (via GitHub)" <gi...@apache.org>.
danielappiagyei-bc commented on issue #11230:
URL: https://github.com/apache/nuttx/issues/11230#issuecomment-1829017987
@acassis @xiaoxiang781216 im going to start working on this so it can make it into the next release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org