You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/10 22:21:14 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5713: ESP32-S3: Sort Kconfig options and style fixes

pkarashchenko commented on a change in pull request #5713:
URL: https://github.com/apache/incubator-nuttx/pull/5713#discussion_r824223307



##########
File path: arch/xtensa/src/esp32s3/Kconfig
##########
@@ -11,24 +11,24 @@ choice
 	prompt "ESP32-S3 Chip Selection"
 	default ARCH_CHIP_ESP32S3WROOM1
 
-config ARCH_CHIP_ESP32S3WROOM1
-	bool "ESP32-S3-WROOM-1"
-	select ESP32S3_FLASH_4M
-	---help---
-		Generic module with an embedded ESP32-S3.
-
-config ARCH_CHIP_ESP32S3WROOM2
-	bool "ESP32-S3-WROOM-2"
-	select ESP32S3_FLASH_16M
-	select ESP32S3_PSRAM_8M
-	---help---
-		Generic module with an embedded ESP32-S3.
-
-config ARCH_CHIP_ESP32S3MINI1
-	bool "ESP32-S3-MINI-1"
-	select ESP32S3_FLASH_8M
-	---help---
-		Generic module with an embedded ESP32-S3.
+	config ARCH_CHIP_ESP32S3WROOM1
+		bool "ESP32-S3-WROOM-1"
+		select ESP32S3_FLASH_4M
+		---help---
+			Generic module with an embedded ESP32-S3.
+
+	config ARCH_CHIP_ESP32S3WROOM2
+		bool "ESP32-S3-WROOM-2"
+		select ESP32S3_FLASH_16M
+		select ESP32S3_PSRAM_8M
+		---help---
+			Generic module with an embedded ESP32-S3.
+
+	config ARCH_CHIP_ESP32S3MINI1
+		bool "ESP32-S3-MINI-1"
+		select ESP32S3_FLASH_8M
+		---help---
+			Generic module with an embedded ESP32-S3.

Review comment:
       I explored a lot of Kconfig files and see that most of those does not have special alignment inside the `choice` section. I think it is better to remove extra TABs in other places rather than adding here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org