You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by Roman Shaposhnik <ro...@shaposhnik.org> on 2015/12/27 00:53:27 UTC
Updating source file licensing and copyright notices
Hi!
I'd like to propose we pull the following PR into
master and RC branch:
https://github.com/apache/incubator-hawq/pull/220
I'd also like to request all of our mentors taking
a special look at this one.
Thanks,
Roman.
Re: Updating source file licensing and copyright notices
Posted by Thejas Nair <th...@gmail.com>.
+1
The changes look good to me.
On Sat, Dec 26, 2015 at 3:53 PM, Roman Shaposhnik <ro...@shaposhnik.org> wrote:
> Hi!
>
> I'd like to propose we pull the following PR into
> master and RC branch:
> https://github.com/apache/incubator-hawq/pull/220
>
> I'd also like to request all of our mentors taking
> a special look at this one.
>
> Thanks,
> Roman.
Re: Updating source file licensing and copyright notices
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
Agreed - someone is wrong on the Internet. I will poke some of our
members who work for RH and see if they can look into it, but HAWQ
shouldn't be held accountable for that...
Thanks! -- justin
On Tue, Dec 29, 2015 at 1:59 AM, Roman Shaposhnik <ro...@shaposhnik.org> wrote:
> On Sun, Dec 27, 2015 at 7:38 PM, Justin Erenkrantz
> <ju...@erenkrantz.com> wrote:
>> Well, someone at Red Hat is wrong. We have never used ASLv2 to refer
>> to our license... -- justin
>
> I guess I don't disagree, but then we actually have to take it up with
> upstream Fedora
> folks: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing
>
> And even then there's tons of packages already using it.
>
> Thanks,
> Roman.
Re: Updating source file licensing and copyright notices
Posted by Roman Shaposhnik <ro...@shaposhnik.org>.
On Sun, Dec 27, 2015 at 7:38 PM, Justin Erenkrantz
<ju...@erenkrantz.com> wrote:
> Well, someone at Red Hat is wrong. We have never used ASLv2 to refer
> to our license... -- justin
I guess I don't disagree, but then we actually have to take it up with
upstream Fedora
folks: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing
And even then there's tons of packages already using it.
Thanks,
Roman.
Re: Updating source file licensing and copyright notices
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
Well, someone at Red Hat is wrong. We have never used ASLv2 to refer
to our license... -- justin
On Sun, Dec 27, 2015 at 2:44 PM, Roman Shaposhnik <ro...@shaposhnik.org> wrote:
> On Sun, Dec 27, 2015 at 5:00 AM, Justin Erenkrantz
> <ju...@erenkrantz.com> wrote:
>> Looks good to me. +1.
>>
>> One nit, rather than abbreviating Apache License v2 to ASLv2 in Gradle file,
>> it should likely be the full expansion or ALv2.
>
> That bit is actually what gets embedded into the RPM License field. And it sems
> that's the way to reference Apache License v2 according to RPM packaging
> guidelines.
>
> Thanks,
> Roman.
Re: Updating source file licensing and copyright notices
Posted by Roman Shaposhnik <ro...@shaposhnik.org>.
On Sun, Dec 27, 2015 at 5:00 AM, Justin Erenkrantz
<ju...@erenkrantz.com> wrote:
> Looks good to me. +1.
>
> One nit, rather than abbreviating Apache License v2 to ASLv2 in Gradle file,
> it should likely be the full expansion or ALv2.
That bit is actually what gets embedded into the RPM License field. And it sems
that's the way to reference Apache License v2 according to RPM packaging
guidelines.
Thanks,
Roman.
Re: Updating source file licensing and copyright notices
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
Looks good to me. +1.
One nit, rather than abbreviating Apache License v2 to ASLv2 in Gradle
file, it should likely be the full expansion or ALv2.
Cheers. -- justin
On Saturday, December 26, 2015, Roman Shaposhnik <ro...@shaposhnik.org>
wrote:
> Hi!
>
> I'd like to propose we pull the following PR into
> master and RC branch:
> https://github.com/apache/incubator-hawq/pull/220
>
> I'd also like to request all of our mentors taking
> a special look at this one.
>
> Thanks,
> Roman.
>
Re: Updating source file licensing and copyright notices
Posted by Alan Gates <ga...@apache.org>.
+1. I looked through the changes and they look reasonable. Rat seems
happy with them as well.
Alan.
Roman Shaposhnik wrote:
> Hi!
>
> I'd like to propose we pull the following PR into
> master and RC branch:
> https://github.com/apache/incubator-hawq/pull/220
>
> I'd also like to request all of our mentors taking
> a special look at this one.
>
> Thanks,
> Roman.