You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/04/03 07:59:57 UTC

[GitHub] mkiiskila commented on a change in pull request #934: util/parse - Additional parsing functions.

mkiiskila commented on a change in pull request #934: util/parse - Additional parsing functions.
URL: https://github.com/apache/mynewt-core/pull/934#discussion_r178735606
 
 

 ##########
 File path: net/ip/mn_socket/include/mn_socket/mn_socket.h
 ##########
 @@ -187,6 +187,9 @@ int mn_close(struct mn_socket *);
 /*
  * Address conversion
  */
+
+#define MN_INET6_MAX_LEN    (39)    /* Does not include terminating \0. */
 
 Review comment:
   To match the naming of the other items should use the following instead. Also note the size. And if adding this one, probably should add the MN_INET_ADDRSTRLEN there as well :)
   
   #define MN_INET6_ADDRSTRLEN        46

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services