You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/25 20:33:27 UTC
Review Request 25031: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25031/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Timothy St. Clair.
Bugs: MESOS-1727
https://issues.apache.org/jira/browse/MESOS-1727
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/configure.ac 053cf665597bd36c302272136d964bf6949b2993
Diff: https://reviews.apache.org/r/25031/diff/
Testing
-------
./bootstrap.sh
./configure
Thanks,
Jie Yu
Re: Review Request 25031: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25031/#review51422
-----------------------------------------------------------
Ship it!
Same comment re: '_init' symbol.
- Benjamin Hindman
On Aug. 25, 2014, 6:33 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25031/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 6:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-1727
> https://issues.apache.org/jira/browse/MESOS-1727
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 053cf665597bd36c302272136d964bf6949b2993
>
> Diff: https://reviews.apache.org/r/25031/diff/
>
>
> Testing
> -------
>
> ./bootstrap.sh
> ./configure
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 25031: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 26, 2014, 12:39 a.m., Timothy St. Clair wrote:
> > Provided the license is ok, I'm a ship it!
It has the same license as m4/acx_pthread.m4 which already exists in the repo.
However, all of them are GNU with AC exception, do you think that's ok?
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25031/#review51469
-----------------------------------------------------------
On Aug. 25, 2014, 11:30 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25031/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 11:30 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-1727
> https://issues.apache.org/jira/browse/MESOS-1727
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 053cf665597bd36c302272136d964bf6949b2993
> 3rdparty/libprocess/m4/ax_cxx_check_lib.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25031/diff/
>
>
> Testing
> -------
>
> ./bootstrap.sh
> ./configure
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 25031: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 26, 2014, 12:39 a.m., Timothy St. Clair wrote:
> > Provided the license is ok, I'm a ship it!
>
> Jie Yu wrote:
> It has the same license as m4/acx_pthread.m4 which already exists in the repo.
>
> However, all of them are GNU with AC exception, do you think that's ok?
Not a lawyer, still asking around.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25031/#review51469
-----------------------------------------------------------
On Aug. 25, 2014, 11:30 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25031/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 11:30 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-1727
> https://issues.apache.org/jira/browse/MESOS-1727
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 053cf665597bd36c302272136d964bf6949b2993
> 3rdparty/libprocess/m4/ax_cxx_check_lib.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25031/diff/
>
>
> Testing
> -------
>
> ./bootstrap.sh
> ./configure
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 25031: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25031/#review51469
-----------------------------------------------------------
Provided the license is ok, I'm a ship it!
- Timothy St. Clair
On Aug. 25, 2014, 11:30 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25031/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 11:30 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-1727
> https://issues.apache.org/jira/browse/MESOS-1727
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 053cf665597bd36c302272136d964bf6949b2993
> 3rdparty/libprocess/m4/ax_cxx_check_lib.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25031/diff/
>
>
> Testing
> -------
>
> ./bootstrap.sh
> ./configure
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 25031: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25031/
-----------------------------------------------------------
(Updated Aug. 25, 2014, 11:30 p.m.)
Review request for mesos, Benjamin Hindman and Timothy St. Clair.
Changes
-------
Similar to 25030.
Bugs: MESOS-1727
https://issues.apache.org/jira/browse/MESOS-1727
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 053cf665597bd36c302272136d964bf6949b2993
3rdparty/libprocess/m4/ax_cxx_check_lib.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/25031/diff/
Testing
-------
./bootstrap.sh
./configure
Thanks,
Jie Yu