You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/08 18:28:45 UTC

[GitHub] tillrohrmann closed pull request #6946: [FLINK-10700] [cluster managerment] Remove LegacyStandaloneClusterDes…

tillrohrmann closed pull request #6946: [FLINK-10700] [cluster managerment] Remove LegacyStandaloneClusterDes…
URL: https://github.com/apache/flink/pull/6946
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/flink-clients/src/main/java/org/apache/flink/client/deployment/LegacyStandaloneClusterDescriptor.java b/flink-clients/src/main/java/org/apache/flink/client/deployment/LegacyStandaloneClusterDescriptor.java
deleted file mode 100644
index b44897054d6..00000000000
--- a/flink-clients/src/main/java/org/apache/flink/client/deployment/LegacyStandaloneClusterDescriptor.java
+++ /dev/null
@@ -1,76 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.client.deployment;
-
-import org.apache.flink.client.program.StandaloneClusterClient;
-import org.apache.flink.configuration.Configuration;
-import org.apache.flink.configuration.JobManagerOptions;
-import org.apache.flink.runtime.jobgraph.JobGraph;
-import org.apache.flink.util.FlinkException;
-
-/**
- * A deployment descriptor for an existing cluster.
- */
-public class LegacyStandaloneClusterDescriptor implements ClusterDescriptor<StandaloneClusterId> {
-
-	private final Configuration config;
-
-	public LegacyStandaloneClusterDescriptor(Configuration config) {
-		this.config = config;
-	}
-
-	@Override
-	public String getClusterDescription() {
-		String host = config.getString(JobManagerOptions.ADDRESS, "");
-		int port = config.getInteger(JobManagerOptions.PORT, -1);
-		return "Standalone cluster at " + host + ":" + port;
-	}
-
-	@Override
-	public StandaloneClusterClient retrieve(StandaloneClusterId standaloneClusterId) throws ClusterRetrieveException {
-		try {
-			return new StandaloneClusterClient(config);
-		} catch (Exception e) {
-			throw new ClusterRetrieveException("Couldn't retrieve standalone cluster", e);
-		}
-	}
-
-	@Override
-	public StandaloneClusterClient deploySessionCluster(ClusterSpecification clusterSpecification) {
-		throw new UnsupportedOperationException("Can't deploy a standalone cluster.");
-	}
-
-	@Override
-	public StandaloneClusterClient deployJobCluster(
-		ClusterSpecification clusterSpecification,
-		JobGraph jobGraph,
-		boolean detached) {
-		throw new UnsupportedOperationException("Can't deploy a standalone per-job cluster.");
-	}
-
-	@Override
-	public void killCluster(StandaloneClusterId clusterId) throws FlinkException {
-		throw new UnsupportedOperationException("Cannot terminate standalone clusters.");
-	}
-
-	@Override
-	public void close() throws Exception {
-		// nothing to do
-	}
-}


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services