You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/12/07 20:39:47 UTC

[GitHub] [pinot] jayeshchoudhary commented on pull request #9888: UI: fix blank screen when redirect to unknown app route

jayeshchoudhary commented on PR #9888:
URL: https://github.com/apache/pinot/pull/9888#issuecomment-1341566759

   > @jayeshchoudhary thanks for looking into this. I understand this is simply a function of whether there's a trailing `/` or not?
   
   @apucher actually the issue was after login via OIDC auth, the redirect url had other params as well along with access token
   eg - {url domain}/#access_token=abc&expiry=123&token_type=bearer. But UI was only expecting access_token and after removing access_token the final redirect url did not match any known UI screen. hence returned a blank screen.
   I have added a check to make sure we don't redirect to any unknown screen.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org