[jira] [Commented] (FLINK-9276) Improve error message when TaskManager fails

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463579#comment-16463579 ] 

ASF GitHub Bot commented on FLINK-9276:
---------------------------------------

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/5954

    [FLINK-9276] Improve error message when TaskManager fails

    ## What is the purpose of the change
    
    *This pull request improves error message when TaskManager fails*
    
    
    ## Brief change log
    
      - *add a Exception param from method `SlotPoolGateway#releaseTaskManager`*
      - *refactor the usage of method `SlotPoolGateway#releaseTaskManager`*
    
    ## Verifying this change
    
    
    This change is already covered by existing tests, such as *SchedulerTestBase/SchedulerIsolatedTasks*.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-9276

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5954.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5954
    
----
commit 904f762e6b495ea6b4ffd445b9168f001f74be26
Author: yanghua <ya...@...>
Date:   2018-05-04T08:52:38Z

    [FLINK-9276] Improve error message when TaskManager fails

----


> Improve error message when TaskManager fails
> --------------------------------------------
>
>                 Key: FLINK-9276
>                 URL: https://issues.apache.org/jira/browse/FLINK-9276
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Stephan Ewen
>            Assignee: vinoyang
>            Priority: Critical
>
> When a TaskManager fails, we frequently get a message
> {code}
> org.apache.flink.util.FlinkException: Releasing TaskManager container_1524853016208_0001_01_000102
> {code}
> This message is misleading in that it sounds like an intended operation, when it really is a failure of a container that the {{ResourceManager}} reports to the {{JobManager}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)