You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/06/26 13:27:23 UTC
Review Request 35920: Change EXPECT to ASSERT when relying in the
assertion afterwards.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35920/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Timothy Chen.
Repository: mesos
Description
-------
Change EXPECT to ASSERT when relying in the assertion afterwards.
Diffs
-----
src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e
Diff: https://reviews.apache.org/r/35920/diff/
Testing
-------
make check (including docker tests)
Thanks,
Joerg Schad
Re: Review Request 35920: Change EXPECT to ASSERT when relying in the
assertion afterwards.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35920/#review89484
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On June 26, 2015, 4:27 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35920/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 4:27 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Change EXPECT to ASSERT when relying in the assertion afterwards.
>
>
> Diffs
> -----
>
> src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e
>
> Diff: https://reviews.apache.org/r/35920/diff/
>
>
> Testing
> -------
>
> make check (including docker tests)
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 35920: Change EXPECT to ASSERT when relying in the
assertion afterwards.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35920/#review89488
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35920]
All tests passed.
- Mesos ReviewBot
On June 26, 2015, 11:27 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35920/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 11:27 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Change EXPECT to ASSERT when relying in the assertion afterwards.
>
>
> Diffs
> -----
>
> src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e
>
> Diff: https://reviews.apache.org/r/35920/diff/
>
>
> Testing
> -------
>
> make check (including docker tests)
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 35920: Change EXPECT to ASSERT when relying on the
assertion afterwards.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35920/#review89503
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On June 26, 2015, 1:12 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35920/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 1:12 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Change EXPECT to ASSERT when relying on the assertion afterwards.
>
>
> Diffs
> -----
>
> src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e
>
> Diff: https://reviews.apache.org/r/35920/diff/
>
>
> Testing
> -------
>
> make check (including docker tests)
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 35920: Change EXPECT to ASSERT when relying on the
assertion afterwards.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35920/
-----------------------------------------------------------
(Updated June 26, 2015, 3:24 p.m.)
Review request for mesos, Bernd Mathiske and Timothy Chen.
Bugs: MESOS-2944
https://issues.apache.org/jira/browse/MESOS-2944
Repository: mesos
Description
-------
Change EXPECT to ASSERT when relying on the assertion afterwards.
Diffs
-----
src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e
Diff: https://reviews.apache.org/r/35920/diff/
Testing
-------
make check (including docker tests)
Thanks,
Joerg Schad
Re: Review Request 35920: Change EXPECT to ASSERT when relying on the
assertion afterwards.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35920/
-----------------------------------------------------------
(Updated June 26, 2015, 1:12 p.m.)
Review request for mesos, Bernd Mathiske and Timothy Chen.
Summary (updated)
-----------------
Change EXPECT to ASSERT when relying on the assertion afterwards.
Repository: mesos
Description (updated)
-------
Change EXPECT to ASSERT when relying on the assertion afterwards.
Diffs
-----
src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e
Diff: https://reviews.apache.org/r/35920/diff/
Testing
-------
make check (including docker tests)
Thanks,
Joerg Schad