You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/11 09:42:51 UTC
[GitHub] [superset] ofekisr edited a comment on pull request #17399: refactor(ChartData): move ChartDataResult enums to common
ofekisr edited a comment on pull request #17399:
URL: https://github.com/apache/superset/pull/17399#issuecomment-966154514
> Since these are called `ChartData*`, should we consider moving them to `superset/charts`? And if not, should these actually be renamed to correspond more to the classes in `superset/common`, so something like `Query*`?
@villebro
I agree with you but we should do it after we move all other components who use it to charts as well
in case we will understand that is not conceptually possible, we should change the enums names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org